add functions to call lib through python#44
Open
k0rventen wants to merge 1 commit intoscaleway:devfrom
k0rventen:master
Open
add functions to call lib through python#44k0rventen wants to merge 1 commit intoscaleway:devfrom k0rventen:master
k0rventen wants to merge 1 commit intoscaleway:devfrom
k0rventen:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I think it would be great to be able to call the lib directly from python code, so it would be possible to have a programmatic approach to importing devices.
I've added a few functions to start, for now we can import / interconnect devices using a configuration generated by a script that would call the netbox-netprod-importer lib, but the config of the lib (url of netbox etc) still needs to be a file loaded by netbox_netprod_importer.config.get_config(). I don't know what would be the best approach regarding this.
As an example, one could use the lib like so :
It's clearly not ready to be merged, but maybe you would have ideas on how to implement this as you know better the lib than I do.
Thx,