feat: add support for devcontainers#5366
Open
remyleone wants to merge 4 commits intoscaleway:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5366 +/- ##
==========================================
+ Coverage 55.53% 55.57% +0.03%
==========================================
Files 320 322 +2
Lines 72408 72649 +241
==========================================
+ Hits 40212 40372 +160
- Misses 30702 30771 +69
- Partials 1494 1506 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds Dev Container automation to keep the repository’s development container configuration up to date and continuously validated in CI.
Changes:
- Add a GitHub Actions workflow that builds/runs the devcontainer and executes
go run ./cmd/scw --help. - Enable Dependabot updates for the
devcontainersecosystem. - Introduce
.devcontainerconfiguration (Dockerfile + devcontainer.json) for local development and CI validation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/devcontainer.yml |
New CI workflow to build and execute a command inside the devcontainer on PRs. |
.github/dependabot.yml |
Adds monthly Dependabot updates for devcontainer dependencies. |
.devcontainer/devcontainer.json |
Defines the devcontainer build, VS Code settings/extensions, env passthrough, and runtime args. |
.devcontainer/Dockerfile |
Minimal Dockerfile that selects the Go devcontainer base image via VARIANT. |
Comments suppressed due to low confidence (1)
.devcontainer/devcontainer.json:11
- The comment describing valid Go
VARIANTvalues is outdated (mentions 1.18/1.17 and buster/bullseye), but the config now usesdev-1.26-bookworm. Updating these comments to match the actual image/tag scheme used here will reduce confusion for future edits.
// Update the VARIANT arg to pick a version of Go: 1, 1.18, 1.17
// Append -bullseye or -buster to pin to an OS version.
// Use -bullseye variants on local arm64/Apple Silicon.
"VARIANT": "dev-1.26-bookworm",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: