Skip to content

feat(analytics): default config #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

feat(analytics): default config #2679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-corners-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@scaleway/use-analytics": patch
---

change default config
7 changes: 5 additions & 2 deletions packages/use-analytics/src/analytics/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import type { ConsentOptions, LoadOptions } from '@rudderstack/analytics-js'

export const defaultConsentOptions: ConsentOptions = {
trackConsent: true,
discardPreConsentEvents: true,
trackConsent: false,
/**
* The discardPreConsentEvents parameter in RudderStack's JavaScript SDK determines what happens to events that are generated before the user provides consent (pre-consent events):
*/
discardPreConsentEvents: false,
storage: {
type: 'cookieStorage',
},
Expand Down
6 changes: 1 addition & 5 deletions packages/use-analytics/src/analytics/useAnalytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,11 @@
})

analytics.ready(() => {
// @ts-expect-error blabla
// @ts-expect-error tracklink is added to the analytics setup to simplify migration from segment, should be remove.
setAnalytics({ ...analytics, trackLink: trackLink(analytics) })

Check warning on line 132 in packages/use-analytics/src/analytics/useAnalytics.tsx

View workflow job for this annotation

GitHub Actions / lint 

`trackLink` is deprecated. this function is a wrapper of a Track to facilitate the migration from segment to rudderstack
setIsAnalyticsReady(true)
})
}
// else if (!shouldLoad && !needConsent ) {
// // When user has refused tracking, set ready anyway
// setIsAnalyticsReady(true)
// }
}, [onError, settings, loadOptions, shouldLoad])

const value = useMemo<AnalyticsContextInterface<T>>(() => {
Expand Down
3 changes: 3 additions & 0 deletions packages/use-analytics/src/analytics/useDestinations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const useDestinations = (config: Config) => {
AnalyticsIntegration[] | undefined
>(undefined)

// TODO: use useDataloader to add more cache.
useEffect(() => {
const fetchDestinations = async () => {
if (config.analytics?.cdnURL && config.analytics.writeKey) {
Expand All @@ -52,6 +53,8 @@ export const useDestinations = (config: Config) => {
if (!response.ok) {
throw new Error('Failed to fetch integrations from source')
}

// TODO: use zod to safe parse and add an error callback in case the schema changed.
const json = (await response.json()) as AnalyticsConfig

return transformConfigToDestinations(json)
Expand Down
Loading