Skip to content

fix(analytics): add default config url #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix(analytics): add default config url #2708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/evil-doodles-tell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@scaleway/use-analytics": patch
---

add configUrl setting by default
1 change: 1 addition & 0 deletions packages/use-analytics/src/analytics/useAnalytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@

analytics.load(settings.writeKey, settings.cdnURL, {
...defaultLoadOptions,
configUrl: settings.cdnURL,
destSDKBaseURL: destSDKBaseURL(settings.cdnURL),
pluginsSDKBaseURL: pluginsSDKBaseURL(settings.cdnURL),
onLoaded: (rudderAnalytics: Analytics) => {
Expand All @@ -129,7 +130,7 @@

analytics.ready(() => {
// @ts-expect-error tracklink is added to the analytics setup to simplify migration from segment, should be remove.
setAnalytics({ ...analytics, trackLink: trackLink(analytics) })

Check warning on line 133 in packages/use-analytics/src/analytics/useAnalytics.tsx

View workflow job for this annotation

GitHub Actions / lint 

`trackLink` is deprecated. this function is a wrapper of a Track to facilitate the migration from segment to rudderstack
setIsAnalyticsReady(true)
})
}
Expand Down
Loading