fix: resolve all non-breaking lint warnings and exclude generated files

Author: jremy42

biome.json

@@ -112,6 +112,12 @@
     }
   },
   "overrides": [
+    {
+      "includes": ["packages_generated/**"],
+      "linter": {
+        "enabled": false
+      }
+    },
     {
       "includes": ["**/dist/**"],
       "linter": {

packages/client/src/helpers/__tests__/marshalling.test.ts

@@ -94,7 +94,6 @@ describe('resolveOneOf', () => {
         [{ default: undefined, param: 'my_key', value: '42' }],
         true,
       ),
-      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key: '42' })
   })
 
@@ -107,7 +106,6 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
-      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_2: '42' })
   })
 
@@ -120,7 +118,6 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
-      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: '42' })
 
     expect(
@@ -131,7 +128,6 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
-      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: '42' })
   })
 
@@ -172,7 +168,6 @@ describe('resolveOneOf', () => {
         ],
         false,
       ),
-      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: false })
   })
 })
@@ -206,7 +201,6 @@ describe('unmarshalArrayOfObject', () => {
   it('unmarshals valid array of object', () => {
     expect(
       unmarshalArrayOfObject(
-        /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
         [{ my_number: 42 }, { my_number: 94 }],
         unmarshaller,
       ),
@@ -235,7 +229,6 @@ describe('unmarshalMapOfObject', () => {
   it('unmarshals valid array of object', () => {
     expect(
       unmarshalMapOfObject(
-        /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
         { 'first-key': { my_number: 42 }, 'second-key': { my_number: 94 } },
         unmarshaller,
       ),

packages/client/src/scw/client-settings.ts

@@ -70,6 +70,7 @@ export interface Settings extends DefaultValues {
  *
  * @internal
  */
+/* biome-ignore lint/complexity/noExcessiveCognitiveComplexity: validation function with multiple checks */
 export const assertValidSettings = (obj: Readonly<Settings>): void => {
   // Default Organization ID.
   if (obj.defaultOrganizationId !== undefined) {

packages/client/src/scw/fetch/response-parser.ts

@@ -50,6 +50,7 @@ export const responseParser =
     unmarshaller: ResponseUnmarshaller<T>,
     responseType: 'json' | 'text' | 'blob',
   ) =>
+  /* biome-ignore lint/complexity/noExcessiveCognitiveComplexity: response parsing with multiple content types and error handling */
   async (response: Response): Promise<T> => {
     if (!isResponse(response)) {
       throw new TypeError('Invalid response object')

packages/configuration-loader/src/config-loader.ts

@@ -55,13 +55,11 @@ export const loadAllProfilesFromConfigurationFile = (
   }
   const configs = loadConfigurationFromFile(filePath)
 
-  return Object.keys(configs).reduce<Record<string, Profile>>(
-    (prev, pKey) => ({
-      ...prev,
-      [pKey]: convertFileConfigToSDK(configs[pKey]),
-    }),
-    {},
-  )
+  const result: Record<string, Profile> = {}
+  for (const pKey of Object.keys(configs)) {
+    result[pKey] = convertFileConfigToSDK(configs[pKey])
+  }
+  return result
 }
 
 /**

packages/configuration-loader/src/yml-loader.ts

@@ -15,14 +15,15 @@ const DETECT_ITEM_REGEX = /^\s*(.+?)\s*:\s*(.+?)\s*$/
  */
 export const convertYamlToConfiguration = (
   input: string | null,
+  /* biome-ignore lint/complexity/noExcessiveCognitiveComplexity: YAML parsing with multiple states */
 ): ConfigurationType => {
   let foundProfilesKey = false
   let currentSection: string | undefined = 'default'
   const map: ConfigurationType = {}
   if (typeof input !== 'string') {
     return map
   }
-  input.split(/\r?\n/).forEach(rawLine => {
+  for (const rawLine of input.split(/\r?\n/)) {
     // remove comments
     const line = rawLine.split(STRIP_COMMENT_REGEX)[0]
     // parse sections
@@ -45,7 +46,7 @@ export const convertYamlToConfiguration = (
         ;[, , map[currentSection][item[1]]] = item
       }
     }
-  })
+  }
 
   return map
 }

scripts/setupNewProducts.ts

@@ -20,6 +20,7 @@ import { cwd } from 'node:process'
 import type { ParseArgsConfig } from 'node:util'
 import { parseArgs } from 'node:util'
 import { snakeToSlug } from './helpers'
+import type { PackageJSON } from './types'
 
 type Scope = '@scaleway' | '@scaleway-internal'
 
@@ -81,7 +82,8 @@ function walkHasGenFiles(root: string): boolean {
   if (!existsSync(root)) return false
   const stack = [root]
   while (stack.length) {
-    const p = stack.pop()!
+    const p = stack.pop()
+    if (!p) break
     const st = statSync(p)
     if (st.isDirectory()) {
       for (const name of readdirSync(p)) stack.push(join(p, name))
@@ -120,7 +122,7 @@ function detectPackageScope(sdkPackageJsonPath: string): Scope {
     warn('⚠️  SDK package.json not found, using @scaleway scope')
     return '@scaleway'
   }
-  const sdkPackage = safeReadJson(sdkPackageJsonPath) as any
+  const sdkPackage = safeReadJson(sdkPackageJsonPath) as PackageJSON
   const deps: Record<string, string> = sdkPackage?.dependencies ?? {}
   const hasInternal = Object.keys(deps).some(k =>
     k.startsWith('@scaleway-internal/sdk-'),
@@ -138,7 +140,7 @@ function updateSdkPackageJson(
     return { added: [] }
   }
 
-  const sdkPackage = safeReadJson(sdkPackageJsonPath) as any
+  const sdkPackage = safeReadJson(sdkPackageJsonPath) as PackageJSON
   sdkPackage.dependencies = sdkPackage.dependencies ?? {}
   sdkPackage.devDependencies = sdkPackage.devDependencies ?? {}