Skip to content

fix(secret_manager): break change due to scheduled deletion #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(secret_manager): break change due to scheduled deletion #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/clients/src/api/secret/v1beta1/api.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export class API extends ParentAPI {
path: `/secret-manager/v1beta1/regions/${validatePathParam('region', request.region ?? this.client.settings.defaultRegion)}/secrets/${validatePathParam('secretId', request.secretId)}`,
})

protected pageOfListSecrets = (request: Readonly<ListSecretsRequest> = {}) =>
protected pageOfListSecrets = (request: Readonly<ListSecretsRequest>) =>
this.client.fetch<ListSecretsResponse>(
{
method: 'GET',
Expand Down Expand Up @@ -176,7 +176,7 @@ export class API extends ParentAPI {
* @param request - The request {@link ListSecretsRequest}
* @returns A Promise of ListSecretsResponse
*/
listSecrets = (request: Readonly<ListSecretsRequest> = {}) =>
listSecrets = (request: Readonly<ListSecretsRequest>) =>
enrichForPagination('secrets', this.pageOfListSecrets, request)

/**
Expand Down
5 changes: 3 additions & 2 deletions packages/clients/src/api/secret/v1beta1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,10 @@ export type ListSecretsRequest = {
type?: SecretType
/**
* Filter by whether the secret was scheduled for deletion / not scheduled for
* deletion (optional).
* deletion. By default, it will display only not scheduled for deletion
* secrets.
*/
scheduledForDeletion?: boolean
scheduledForDeletion: boolean
}

export interface ListSecretsResponse {
Expand Down
Loading