Skip to content

feat(s2s_vpn): use secret manager to store connection psk #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

feat(s2s_vpn): use secret manager to store connection psk #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages_generated/s2s_vpn/src/v1alpha1/marshalling.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ export const unmarshalConnection = (data: unknown): Connection => {
projectId: data.project_id,
region: data.region,
routePropagationEnabled: data.route_propagation_enabled,
secretId: data.secret_id,
secretRevision: data.secret_revision,
status: data.status,
tags: data.tags,
tunnelStatus: data.tunnel_status,
Expand Down
16 changes: 12 additions & 4 deletions packages_generated/s2s_vpn/src/v1alpha1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ export interface Connection {
* Who initiates the IPsec tunnel.
*/
initiationPolicy: ConnectionInitiationPolicy
/**
* ID of the secret in Secret Manager which contains the PSK.
*/
secretId: string
/**
* Version number of the secret in Secret Manager which contains the PSK.
*/
secretRevision: number
/**
* List of IKE v2 ciphers proposed for the IPsec tunnel.
*/
Expand Down Expand Up @@ -450,9 +458,9 @@ export interface CreateConnectionResponse {
*/
connection?: Connection
/**
* New PSK generated for this connection.
* @deprecated Deprecated, use secret_id & secret_revision fields.
*/
preSharedKey: string
preSharedKey?: string
}

export type CreateCustomerGatewayRequest = {
Expand Down Expand Up @@ -940,9 +948,9 @@ export interface RenewConnectionPskResponse {
*/
connection?: Connection
/**
* New PSK generated for this connection.
* @deprecated Deprecated, use secret_id & secret_revision fields.
*/
preSharedKey: string
preSharedKey?: string
}

export type SetRoutingPolicyRequest = {
Expand Down
Loading