Skip to content

feat(tem): deprecate accept tos on create domain #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

feat(tem): deprecate accept tos on create domain #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions scaleway-async/scaleway_async/tem/v1alpha1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ async def list_emails(
:param since: (Optional) List emails created after this date.
:param until: (Optional) List emails created before this date.
:param mail_from: (Optional) List emails sent with this sender's email address.
:param mail_to: List emails sent to this recipient's email address.
:param mail_to: Deprecated. List emails sent to this recipient's email address.
:param mail_rcpt: (Optional) List emails sent to this recipient's email address.
:param statuses: (Optional) List emails with any of these statuses.
:param subject: (Optional) List emails with this subject.
Expand Down Expand Up @@ -337,7 +337,7 @@ async def list_emails_all(
:param since: (Optional) List emails created after this date.
:param until: (Optional) List emails created before this date.
:param mail_from: (Optional) List emails sent with this sender's email address.
:param mail_to: List emails sent to this recipient's email address.
:param mail_to: Deprecated. List emails sent to this recipient's email address.
:param mail_rcpt: (Optional) List emails sent to this recipient's email address.
:param statuses: (Optional) List emails with any of these statuses.
:param subject: (Optional) List emails with this subject.
Expand Down Expand Up @@ -461,27 +461,26 @@ async def create_domain(
self,
*,
domain_name: str,
accept_tos: bool,
autoconfig: bool,
region: Optional[ScwRegion] = None,
project_id: Optional[str] = None,
accept_tos: Optional[bool] = None,
) -> Domain:
"""
Register a domain in a project.
You must specify the `region`, `project_id` and `domain_name` to register a domain in a specific Project.
:param domain_name: Fully qualified domain dame.
:param accept_tos: Accept Scaleway's Terms of Service.
:param autoconfig: Activate auto-configuration of the domain's DNS zone.
:param region: Region to target. If none is passed will use default region from the config.
:param project_id: ID of the project to which the domain belongs.
:param accept_tos: Deprecated. Accept Scaleway's Terms of Service.
:return: :class:`Domain <Domain>`

Usage:
::

result = await api.create_domain(
domain_name="example",
accept_tos=False,
autoconfig=False,
)
"""
Expand All @@ -496,10 +495,10 @@ async def create_domain(
body=marshal_CreateDomainRequest(
CreateDomainRequest(
domain_name=domain_name,
accept_tos=accept_tos,
autoconfig=autoconfig,
region=region,
project_id=project_id,
accept_tos=accept_tos,
),
self.client,
),
Expand Down
6 changes: 3 additions & 3 deletions scaleway-async/scaleway_async/tem/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,15 +930,15 @@ def marshal_CreateDomainRequest(
if request.domain_name is not None:
output["domain_name"] = request.domain_name

if request.accept_tos is not None:
output["accept_tos"] = request.accept_tos

if request.autoconfig is not None:
output["autoconfig"] = request.autoconfig

if request.project_id is not None:
output["project_id"] = request.project_id or defaults.default_project_id

if request.accept_tos is not None:
output["accept_tos"] = request.accept_tos

return output


Expand Down
16 changes: 8 additions & 8 deletions scaleway-async/scaleway_async/tem/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ class Email:

rcpt_to: Optional[str]
"""
Email address of the recipient.
Deprecated. Email address of the recipient.
"""

rcpt_type: EmailRcptType
Expand Down Expand Up @@ -578,7 +578,7 @@ class Domain:

last_error: Optional[str]
"""
Error message returned if the last check failed.
Deprecated. Error message returned if the last check failed.
"""

statistics: Optional[DomainStatistics]
Expand Down Expand Up @@ -818,11 +818,6 @@ class CreateDomainRequest:
Fully qualified domain dame.
"""

accept_tos: bool
"""
Accept Scaleway's Terms of Service.
"""

autoconfig: bool
"""
Activate auto-configuration of the domain's DNS zone.
Expand All @@ -838,6 +833,11 @@ class CreateDomainRequest:
ID of the project to which the domain belongs.
"""

accept_tos: Optional[bool]
"""
Deprecated. Accept Scaleway's Terms of Service.
"""


@dataclass
class CreateEmailRequest:
Expand Down Expand Up @@ -1250,7 +1250,7 @@ class ListEmailsRequest:

mail_to: Optional[str]
"""
List emails sent to this recipient's email address.
Deprecated. List emails sent to this recipient's email address.
"""

mail_rcpt: Optional[str]
Expand Down
11 changes: 5 additions & 6 deletions scaleway/scaleway/tem/v1alpha1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def list_emails(
:param since: (Optional) List emails created after this date.
:param until: (Optional) List emails created before this date.
:param mail_from: (Optional) List emails sent with this sender's email address.
:param mail_to: List emails sent to this recipient's email address.
:param mail_to: Deprecated. List emails sent to this recipient's email address.
:param mail_rcpt: (Optional) List emails sent to this recipient's email address.
:param statuses: (Optional) List emails with any of these statuses.
:param subject: (Optional) List emails with this subject.
Expand Down Expand Up @@ -337,7 +337,7 @@ def list_emails_all(
:param since: (Optional) List emails created after this date.
:param until: (Optional) List emails created before this date.
:param mail_from: (Optional) List emails sent with this sender's email address.
:param mail_to: List emails sent to this recipient's email address.
:param mail_to: Deprecated. List emails sent to this recipient's email address.
:param mail_rcpt: (Optional) List emails sent to this recipient's email address.
:param statuses: (Optional) List emails with any of these statuses.
:param subject: (Optional) List emails with this subject.
Expand Down Expand Up @@ -461,27 +461,26 @@ def create_domain(
self,
*,
domain_name: str,
accept_tos: bool,
autoconfig: bool,
region: Optional[ScwRegion] = None,
project_id: Optional[str] = None,
accept_tos: Optional[bool] = None,
) -> Domain:
"""
Register a domain in a project.
You must specify the `region`, `project_id` and `domain_name` to register a domain in a specific Project.
:param domain_name: Fully qualified domain dame.
:param accept_tos: Accept Scaleway's Terms of Service.
:param autoconfig: Activate auto-configuration of the domain's DNS zone.
:param region: Region to target. If none is passed will use default region from the config.
:param project_id: ID of the project to which the domain belongs.
:param accept_tos: Deprecated. Accept Scaleway's Terms of Service.
:return: :class:`Domain <Domain>`

Usage:
::

result = api.create_domain(
domain_name="example",
accept_tos=False,
autoconfig=False,
)
"""
Expand All @@ -496,10 +495,10 @@ def create_domain(
body=marshal_CreateDomainRequest(
CreateDomainRequest(
domain_name=domain_name,
accept_tos=accept_tos,
autoconfig=autoconfig,
region=region,
project_id=project_id,
accept_tos=accept_tos,
),
self.client,
),
Expand Down
6 changes: 3 additions & 3 deletions scaleway/scaleway/tem/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,15 +930,15 @@ def marshal_CreateDomainRequest(
if request.domain_name is not None:
output["domain_name"] = request.domain_name

if request.accept_tos is not None:
output["accept_tos"] = request.accept_tos

if request.autoconfig is not None:
output["autoconfig"] = request.autoconfig

if request.project_id is not None:
output["project_id"] = request.project_id or defaults.default_project_id

if request.accept_tos is not None:
output["accept_tos"] = request.accept_tos

return output


Expand Down
16 changes: 8 additions & 8 deletions scaleway/scaleway/tem/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ class Email:

rcpt_to: Optional[str]
"""
Email address of the recipient.
Deprecated. Email address of the recipient.
"""

rcpt_type: EmailRcptType
Expand Down Expand Up @@ -578,7 +578,7 @@ class Domain:

last_error: Optional[str]
"""
Error message returned if the last check failed.
Deprecated. Error message returned if the last check failed.
"""

statistics: Optional[DomainStatistics]
Expand Down Expand Up @@ -818,11 +818,6 @@ class CreateDomainRequest:
Fully qualified domain dame.
"""

accept_tos: bool
"""
Accept Scaleway's Terms of Service.
"""

autoconfig: bool
"""
Activate auto-configuration of the domain's DNS zone.
Expand All @@ -838,6 +833,11 @@ class CreateDomainRequest:
ID of the project to which the domain belongs.
"""

accept_tos: Optional[bool]
"""
Deprecated. Accept Scaleway's Terms of Service.
"""


@dataclass
class CreateEmailRequest:
Expand Down Expand Up @@ -1250,7 +1250,7 @@ class ListEmailsRequest:

mail_to: Optional[str]
"""
List emails sent to this recipient's email address.
Deprecated. List emails sent to this recipient's email address.
"""

mail_rcpt: Optional[str]
Expand Down