Skip to content

fix(deployment): add sandbox param in update call #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(deployment): add sandbox param in update call #250

merged 1 commit into from
Nov 28, 2024

Conversation

@cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Nov 28, 2024

Summary

What's changed?

  • Sandbox param was missing when updating function/container

Why do we need this?

  • This prevents users from changing the Sandbox of their existing functions :/

How have you tested it?

  • Tested locally ✅

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

@cyclimse cyclimse self-assigned this Nov 28, 2024
@cyclimse cyclimse requested review from Bemilie and norbjd November 28, 2024 11:18
@cyclimse cyclimse removed the request for review from norbjd November 28, 2024 13:47
@cyclimse cyclimse merged commit f2c3314 into master Nov 28, 2024
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bemilie Bemilie Bemilie approved these changes

Assignees

@cyclimse cyclimse

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyclimse @Bemilie