Include function message trigger for NATS event #255
Conversation
|
LGTM! Thanks a lot for the contribution! There are some formatting errors can you run I think we should also add SQS triggers afterward, but we can do it on our side. Happy to do a release for this. |
Hi there! Sorry for the late reply. I didn't see the message. I've run Prettier, so it should be all set! Thank you for picking this up! |
|
|
@cyclimse The pipeline is failing due to |
|
Arf, I'm really sorry. We don't have a lot of bandwidth, and have been sitting on it. We've been mostly waiting for someone from the team to test it manually. I'm "doctor" this week so I can take a look. |
| key: value | ||
| key2: value2 | ||
| - nats: | ||
| name: my-nats-event |
There was a problem hiding this comment.
nit: I think it's possible to include this directly in the top-level message, since all triggers can be given a name:
events:
- name: my-nats-event
nats:
scw_nats_config:
...
However, it's okay like this, the API doesn't define a clear standard for what's a trigger and I don't reckon it's a big deal.
| @@ -1,6 +1,6 @@ | |||
| # Events | |||
There was a problem hiding this comment.
praise: thanks for updating the docs, really appreciated 🙏
| @@ -0,0 +1,8370 @@ | |||
| lockfileVersion: "9.0" | |||
There was a problem hiding this comment.
nit: haha I use pnpm as well, but in this case it's better to avoid comitting the lock IMO, since this codebase is supposed to be used with npm
2 participants
Summary
What's changed?
Included the possibility to configure NATS triggers.
Why do we need this?
#254
How have you tested it?
Creating and deleting a nats trigger.
Checklist
Details