fix(scaleway_lb_ip): add support to precise the zone in which the ip was reserved #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
load-balancer
al26p
force-pushed
the
fix/provide_lb_ip_zone
branch
from
4137aae to
24f34cf
Compare
Signed-off-by: Alban PRATS <[email protected]>
al26p
force-pushed
the
fix/provide_lb_ip_zone
branch
from
24f34cf to
cfa5d7a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
- Coverage 71.43% 67.66% -3.78%
==========================================
Files 277 339 +62
Lines 35875 39919 +4044
==========================================
+ Hits 25628 27010 +1382
- Misses 8028 10595 +2567
- Partials 2219 2314 +95 ☔ View full report in Codecov by Sentry. |
yfodil
approved these changes
Nov 13, 2024
Contributor
|
Hello @al26p 👋, thanks a lot for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2802