Skip to content

test(redis): remove flaky tests from redis test suite #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

test(redis): remove flaky tests from redis test suite #2855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
409b89d
fix: remove flaky test from redis test suite
Dec 18, 2024
e862af4
fixup! fix: remove flaky test from redis test suite
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 1 addition & 91 deletions internal/services/redis/cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) {
{
Config: fmt.Sprintf(`
resource scaleway_vpc_private_network private_network {}

resource "scaleway_redis_cluster" "main" {
name = "test_redis_migrate_cluster_size_ipam"
version = "%s"
Expand Down Expand Up @@ -222,96 +222,6 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) {
})
}

func TestAccCluster_MigrateClusterSizeWithStaticEndpoint(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()
latestRedisVersion := getLatestVersion(tt)
clusterID := ""
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
CheckDestroy: isClusterDestroyed(tt),
Steps: []resource.TestStep{
{
Config: fmt.Sprintf(`
resource scaleway_vpc_private_network private_network {}

resource "scaleway_redis_cluster" "main" {
name = "test_redis_migrate_cluster_size_static"
version = "%s"
node_type = "RED1-XS"
user_name = "my_initial_user"
password = "thiZ_is_v&ry_s3cret"
cluster_size = 1
tls_enabled = "true"
private_network {
id = scaleway_vpc_private_network.private_network.id
service_ips = [
"192.168.99.1/24",
]
}
}
`, latestRedisVersion),
Check: resource.ComposeTestCheckFunc(
isClusterPresent(tt, "scaleway_redis_cluster.main"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_static"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "1"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.0", "192.168.99.1/24"),
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
acctest.CheckResourceIDPersisted("scaleway_redis_cluster.main", &clusterID),
),
},
{
Config: fmt.Sprintf(`
resource scaleway_vpc_private_network private_network {}

resource "scaleway_redis_cluster" "main" {
name = "test_redis_migrate_cluster_size_static"
version = "%s"
node_type = "RED1-XS"
user_name = "my_initial_user"
password = "thiZ_is_v&ry_s3cret"
cluster_size = 3
tls_enabled = "true"
private_network {
id = scaleway_vpc_private_network.private_network.id
service_ips = [
"192.168.99.1/24",
"192.168.99.2/24",
"192.168.99.3/24",
"192.168.99.4/24",
"192.168.99.5/24",
]
}
}
`, latestRedisVersion),
Check: resource.ComposeTestCheckFunc(
isClusterPresent(tt, "scaleway_redis_cluster.main"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_static"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "3"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.0", "192.168.99.1/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.1", "192.168.99.2/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.2", "192.168.99.3/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.3", "192.168.99.4/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.4", "192.168.99.5/24"),
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
acctest.CheckResourceIDChanged("scaleway_redis_cluster.main", &clusterID),
),
},
},
})
}

func TestAccCluster_ACL(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()
Expand Down
Loading
Loading