Skip to content

fix(k8s): remove warnings for missing pn #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

fix(k8s): remove warnings for missing pn #2952

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362ef03
feat(k8s): remove warnings for missing pn
Codelax Feb 28, 2025
0dd0b30
lint
Codelax Feb 28, 2025
f7c62a2
Merge branch 'master' into feat/k8s-remove-deprecated-warning
remyleone Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions internal/services/k8s/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,41 +570,29 @@ func ResourceK8SClusterRead(ctx context.Context, d *schema.ResourceData, m inter
_ = d.Set("open_id_connect_config", clusterOpenIDConnectConfigFlatten(cluster))
_ = d.Set("auto_upgrade", clusterAutoUpgradeFlatten(cluster))

var diags diag.Diagnostics

// private_network
pnID := types.FlattenStringPtr(cluster.PrivateNetworkID)
clusterType := d.Get("type").(string)
_ = d.Set("private_network_id", pnID)

if pnID == "" && !strings.HasPrefix(clusterType, "multicloud") {
diags = append(diags, diag.Diagnostic{
Severity: diag.Warning,
Summary: "Public clusters are deprecated",
Detail: "Important: Harden your cluster's security by enabling a free Private Network ASAP. Full public clusters are deprecated and will reach End of Support in Q1 2024.",
})
}
_ = d.Set("private_network_id", types.FlattenStringPtr(cluster.PrivateNetworkID))

////
// Read kubeconfig
////
kubeconfig, err := flattenKubeconfig(ctx, k8sAPI, region, clusterID)
if err != nil {
if httperrors.Is403(err) {
diags = append(diags, diag.Diagnostic{
return diag.Diagnostics{diag.Diagnostic{
Severity: diag.Warning,
Summary: "Cannot read kubeconfig: unauthorized",
Detail: "Got 403 while reading kubeconfig, please check your permissions",
AttributePath: cty.GetAttrPath("kubeconfig"),
})
}}
}
} else {
diags = append(diags, diag.FromErr(err)...)

return diag.FromErr(err)
}

_ = d.Set("kubeconfig", []map[string]interface{}{kubeconfig})

return diags
return nil
}

//gocyclo:ignore
Expand Down
Loading