Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions docs/resources/baremetal_server.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,47 @@ resource "scaleway_baremetal_server" "base" {

```

### Migrate from hourly to monthly plan

To migrate from an hourly to a monthly subscription for a Scaleway Baremetal server, it is important to understand that the migration can only be done by using the data source.
You cannot directly modify the subscription_period of an existing scaleway_baremetal_offer resource. Instead, you must define the monthly offer using the data source and then update the server configuration accordingly.

#### Hourly Plan Example

```terraform
data "scaleway_baremetal_offer" "my_offer" {
zone = "fr-par-1"
name = "EM-B220E-NVME"
subscription_period = "hourly"
}

resource "scaleway_baremetal_server" "server01" {
name = "UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "%s"
install_config_afterward = true
}
```

#### Monthly Plan Example

```terraform
data "scaleway_baremetal_offer" "my_offer" {
zone = "fr-par-1"
name = "EM-B220E-NVME"
subscription_period = "monthly"
}

resource "scaleway_baremetal_server" "server01" {
name = "UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "fr-par-1"
install_config_afterward = true
}
```

**Important** Once you migrate to a monthly subscription, you cannot downgrade back to an hourly plan. Ensure that the monthly plan meets your needs before making the switch.

## Argument Reference

The following arguments are supported:
Expand Down
50 changes: 50 additions & 0 deletions internal/services/baremetal/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ import (
"github.com/scaleway/scaleway-sdk-go/api/baremetal/v1"
baremetalV3 "github.com/scaleway/scaleway-sdk-go/api/baremetal/v3"
"github.com/scaleway/scaleway-sdk-go/scw"
"github.com/scaleway/scaleway-sdk-go/validation"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/meta"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
Expand Down Expand Up @@ -224,3 +226,51 @@ func privateNetworkSetHash(v interface{}) int {

return schema.HashString(buf.String())
}

func getOfferInformations(ctx context.Context, offer interface{}, id string, i interface{}) (*baremetal.Offer, error) {
api, zone, err := NewAPIWithZoneAndID(i, id)
if err != nil {
return nil, err
}

if validation.IsUUID(regional.ExpandID(offer.(string)).ID) {
offerID := regional.ExpandID(offer.(string))

return FindOfferByID(ctx, api, zone.Zone, offerID.ID)
} else {
return api.GetOfferByName(&baremetal.GetOfferByNameRequest{
OfferName: offer.(string),
Zone: zone.Zone,
})
}
}

func customDiffOffer() func(ctx context.Context, diff *schema.ResourceDiff, i interface{}) error {
return func(ctx context.Context, diff *schema.ResourceDiff, i interface{}) error {
if diff.Get("offer") == "" || !diff.HasChange("offer") || diff.Id() == "" {
return nil
}

oldOffer, newOffer := diff.GetChange("offer")

oldOfferInfo, err := getOfferInformations(ctx, oldOffer, diff.Id(), i)
if err != nil {
return errors.New(err.Error())
}

newOfferInfo, err := getOfferInformations(ctx, newOffer, diff.Id(), i)
if err != nil {
return errors.New(err.Error())
}

if oldOfferInfo.Name != newOfferInfo.Name {
return diff.ForceNew("offer")
}

if oldOfferInfo.SubscriptionPeriod == baremetal.OfferSubscriptionPeriodMonthly && newOfferInfo.SubscriptionPeriod == baremetal.OfferSubscriptionPeriodHourly {
return errors.New("invalid plan transition: you cannot transition from a monthly plan to an hourly plan. Only the reverse (hourly to monthly) is supported. Please update your configuration accordingly")
}

return nil
}
}
32 changes: 26 additions & 6 deletions internal/services/baremetal/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/scaleway/terraform-provider-scaleway/v2/internal/dsf"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/account"
"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
Expand Down Expand Up @@ -54,10 +55,10 @@ func ResourceServer() *schema.Resource {
Description: "Hostname of the server",
},
"offer": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Description: "ID or name of the server offer",
Type: schema.TypeString,
Required: true,
Description: "ID or name of the server offer",
ValidateDiagFunc: verify.IsUUIDOrNameOffer(),
DiffSuppressFunc: func(_, oldValue, newValue string, d *schema.ResourceData) bool {
// remove the locality from the IDs when checking diff
if locality.ExpandID(newValue) == locality.ExpandID(oldValue) {
Expand All @@ -68,7 +69,6 @@ func ResourceServer() *schema.Resource {

return ok && newValue == offerName
},
ValidateDiagFunc: verify.IsUUIDOrNameOffer(),
},
"offer_id": {
Type: schema.TypeString,
Expand Down Expand Up @@ -264,8 +264,8 @@ If this behaviour is wanted, please set 'reinstall_on_ssh_key_changes' argument
Description: "The partitioning schema in json format",
},
},

CustomizeDiff: customdiff.Sequence(
customDiffOffer(),
cdf.LocalityCheck("private_network.#.id"),
customDiffPrivateNetworkOption(),
),
Expand Down Expand Up @@ -529,6 +529,26 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m interfa
var serverGetOptionIDs []*baremetal.ServerOption
serverGetOptionIDs = append(serverGetOptionIDs, server.Options...)

if d.HasChange("offer") {
ServerID := regional.ExpandID(server.ID)

_, err = api.MigrateServerToMonthlyOffer(&baremetal.MigrateServerToMonthlyOfferRequest{
Zone: zonedID.Zone,
ServerID: ServerID.ID,
}, scw.WithContext(ctx))
if err != nil {
return diag.FromErr(err)
}

_, err := api.WaitForServer(&baremetal.WaitForServerRequest{
Zone: zonedID.Zone,
ServerID: ServerID.ID,
})
if err != nil {
return diag.FromErr(err)
}
}

if d.HasChange("options") {
options, err := expandOptions(d.Get("options"))
if err != nil {
Expand Down
94 changes: 94 additions & 0 deletions internal/services/baremetal/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,100 @@ func TestAccServer_WithIPAMPrivateNetwork(t *testing.T) {
})
}

func TestAccServer_UpdateSubscriptionPeriod(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

newOffer := "EM-B320E-NVME"

if !IsOfferAvailable(OfferID, Zone, tt) {
t.Skip("Offer is out of stock")
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
),
Steps: []resource.TestStep{
{
Config: fmt.Sprintf(`
data "scaleway_baremetal_offer" "my_offer" {
zone = "%s"
name = "%s"
subscription_period = "hourly"
}

resource "scaleway_baremetal_server" "server01" {
name = "TestAccServer_UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "%s"
install_config_afterward = true
}`, Zone, OfferName, Zone),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("scaleway_baremetal_server.server01", "zone", Zone),
resource.TestCheckResourceAttrPair("scaleway_baremetal_server.server01", "offer_id", "data.scaleway_baremetal_offer.my_offer", "offer_id"),
),
},
{
Config: fmt.Sprintf(`
data "scaleway_baremetal_offer" "my_offer" {
zone = "%s"
name = "%s"
subscription_period = "monthly"
}

resource "scaleway_baremetal_server" "server01" {
name = "TestAccServer_UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "%s"
install_config_afterward = true
}`, Zone, OfferName, Zone),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("scaleway_baremetal_server.server01", "zone", Zone),
resource.TestCheckResourceAttrPair("scaleway_baremetal_server.server01", "offer_id", "data.scaleway_baremetal_offer.my_offer", "offer_id"),
),
},
{
Config: fmt.Sprintf(`
data "scaleway_baremetal_offer" "my_offer" {
zone = "%s"
name = "%s"
subscription_period = "hourly"
}

resource "scaleway_baremetal_server" "server01" {
name = "TestAccServer_UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "%s"
install_config_afterward = true
}`, Zone, OfferName, Zone),
ExpectError: regexp.MustCompile(`invalid plan transition: you cannot transition from a monthly plan to an hourly plan. Only the reverse \(hourly to monthly\) is supported. Please update your configuration accordingly`),
},
{
Config: fmt.Sprintf(`
data "scaleway_baremetal_offer" "my_offer" {
zone = "%s"
name = "%s"
subscription_period = "hourly"
}

resource "scaleway_baremetal_server" "server01" {
name = "Test_UpdateSubscriptionPeriod"
offer = data.scaleway_baremetal_offer.my_offer.offer_id
zone = "%s"
install_config_afterward = true
}`, Zone, newOffer, Zone),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("scaleway_baremetal_server.server01", "zone", "fr-par-1"),
resource.TestCheckResourceAttrPair("scaleway_baremetal_server.server01", "offer_id", "data.scaleway_baremetal_offer.my_offer", "offer_id"),
),
},
},
})
}

func testAccCheckBaremetalServerExists(tt *acctest.TestTools, n string) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
Expand Down
Loading
Loading