-
Notifications
You must be signed in to change notification settings - Fork 133
container: use project_id from provider configuration #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee3784b to
4d8374a
Compare
4d8374a to
9a5e157
Compare
remyleone
reviewed
May 19, 2025
| if !ok { | ||
| containerName := d.Get("name").(string) | ||
|
|
||
| projectID, _, err := meta.ExtractProjectID(d, m) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to ensure that it is taken into account with a test?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test would break without the ForceProjectID in meta.Config
917a68d to
d27a4ac
Compare
29f5548 to
d525d9f
Compare
d525d9f to
85426a2
Compare
remyleone
reviewed
May 20, 2025
Contributor
Author
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user bring recently, in most of the modules, we ignore the
project_idparameter set at the provider level in some cases, because the environment takes precedence over the provider config herepartly fixes #3068
The provider configuration should probably override other configuration sources but this could be impactful / breaking for users used to provide environment variables
The change imply to explicitly find a
project_idat the resource / client level and raise an error if not found, instead of relying on the SDK logic to eventually find it or use an empty string in some cases.=> Now when running the test in CI, we need to inject a project ID in the meta configuration.
But this reveal another corner case: resources calling HTTP GET query with the optional
project_idparameter that where not using it, namespace container datasource for instance, are now using the fake project_id set in the test suite (&project_id=1111111).So we strip this parameter from the query to address these kind of cases