Skip to content

fix(marketplace): update server's possible volume types #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025
Merged

fix(marketplace): update server's possible volume types #3116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e8ade9
doc(instance): update server's possible volume types + read more mark…
Mia-Cross May 27, 2025
ee39890
Merge branch 'master' into instance_doc_root_volume_type_compatibility
Mia-Cross Jun 2, 2025
15f7270
Merge branch 'master' into instance_doc_root_volume_type_compatibility
Mia-Cross Jun 4, 2025
ab93986
Merge branch 'master' into instance_doc_root_volume_type_compatibility
remyleone Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/instance_server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ To retrieve more information by label please use: ```scw marketplace image get l
To find the right size use [this endpoint](https://www.scaleway.com/en/developers/api/instance/#path-instances-list-all-instances) and
check the `volumes_constraint.{min|max}_size` (in bytes) for your `commercial_type`.
Depending on `volume_type`, updates to this field may recreate a new resource.
- `volume_type` - (Optional) Volume type of root volume, can be `b_ssd`, `l_ssd` or `sbs_volume`, default value depends on server type
- `volume_type` - (Optional) Volume type of root volume, can be `l_ssd` or `sbs_volume`, default value depends on server type
Copy link
Member

@remyleone remyleone Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for those different cases?

- `delete_on_termination` - (Defaults to `true`) Forces deletion of the root volume on instance termination.
- `sbs_iops` - (Optional) Choose IOPS of your sbs volume, has to be used with `sbs_volume` for root volume type.

Expand Down
4 changes: 2 additions & 2 deletions internal/services/marketplace/image_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ func DataSourceMarketplaceImageRead(ctx context.Context, d *schema.ResourceData,
zonedID := datasource.NewZonedID(image.ID, zone)
d.SetId(zonedID)
_ = d.Set("zone", zone)
_ = d.Set("label", d.Get("label"))
_ = d.Set("instance_type", d.Get("type"))
_ = d.Set("label", image.Label)
_ = d.Set("instance_type", d.Get("instance_type").(string))
_ = d.Set("image_type", image.Type)

return nil
Expand Down
Loading