Skip to content

fix(rdb): add pagination support for ACL rules #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix(rdb): add pagination support for ACL rules #3207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/rdb/acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func ResourceRdbACLRead(ctx context.Context, d *schema.ResourceData, m any) diag
res, err := rdbAPI.ListInstanceACLRules(&rdb.ListInstanceACLRulesRequest{
Region: region,
InstanceID: instanceID,
}, scw.WithContext(ctx))
}, scw.WithAllPages(), scw.WithContext(ctx))
if err != nil {
if httperrors.Is404(err) {
d.SetId("")
Expand Down
1,755 changes: 1,049 additions & 706 deletions internal/services/rdb/testdata/acl-basic.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,118 changes: 706 additions & 412 deletions internal/services/rdb/testdata/data-source-acl-basic.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading