Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ linters:
- usetesting # Reports uses of functions with replacement inside the testing package. [auto-fix]
- wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]
- whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true]
- wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false]
- wsl_v5 # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false]
- zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]

disable:
Expand Down Expand Up @@ -141,6 +141,11 @@ linters:
reject:
- anon

wsl_v5:
allow-first-in-block: true
allow-whole-block: false
branch-max-lines: 2

exclusions:
rules:
- path: _test\.go
Expand Down
2 changes: 2 additions & 0 deletions internal/services/account/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
func TestAccProject_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
ProviderFactories: tt.ProviderFactories,
CheckDestroy: isProjectDestroyed(tt),
Expand Down Expand Up @@ -52,6 +53,7 @@ func TestAccProject_Basic(t *testing.T) {
func TestAccProject_NoUpdate(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
ProviderFactories: tt.ProviderFactories,
CheckDestroy: isProjectDestroyed(tt),
Expand Down
4 changes: 4 additions & 0 deletions internal/services/applesilicon/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
func TestAccServer_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -67,6 +68,7 @@ func TestAccServer_Basic(t *testing.T) {
func TestAccServer_EnableDisabledVPC(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -121,6 +123,7 @@ func TestAccServer_EnableDisabledVPC(t *testing.T) {
func TestAccServer_EnableVPC(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -265,6 +268,7 @@ func TestAccServer_Commitment(t *testing.T) {

tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 0 additions & 1 deletion internal/services/autoscaling/instance_group_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ func testAccCheckInstanceGroupDestroy(tt *acctest.TestTools) resource.TestCheckF
InstanceGroupID: id,
Zone: zone,
})

if err == nil {
return fmt.Errorf("autoscaling instance group (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 0 additions & 1 deletion internal/services/autoscaling/instance_policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ func testAccCheckInstancePolicyDestroy(tt *acctest.TestTools) resource.TestCheck
PolicyID: id,
Zone: zone,
})

if err == nil {
return fmt.Errorf("autoscaling instance policy (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 0 additions & 1 deletion internal/services/autoscaling/instance_template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ func testAccCheckInstanceTemplateDestroy(tt *acctest.TestTools) resource.TestChe
TemplateID: id,
Zone: zone,
})

if err == nil {
return fmt.Errorf("autoscaling instance template (%s) still exists", rs.Primary.ID)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
func TestAccDataSourceAvailabilityZones_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/baremetal/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,7 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m any) di
}

var serverGetOptionIDs []*baremetal.ServerOption

serverGetOptionIDs = append(serverGetOptionIDs, server.Options...)

if d.HasChange("offer") {
Expand Down
1 change: 1 addition & 0 deletions internal/services/block/snapshot_data_source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccDataSourceSnapshot_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
2 changes: 0 additions & 2 deletions internal/services/block/testfuncs/checks.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ func IsVolumeDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
VolumeID: id,
Zone: zone,
})

if err == nil {
return fmt.Errorf("block volume (%s) still exists", rs.Primary.ID)
}
Expand Down Expand Up @@ -105,7 +104,6 @@ func IsSnapshotDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
SnapshotID: id,
Zone: zone,
})

if err == nil {
return fmt.Errorf("block snapshot (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 1 addition & 0 deletions internal/services/block/volume_data_source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccDataSourceVolume_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 0 additions & 1 deletion internal/services/cockpit/source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ func isSourceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
Region: region,
DataSourceID: ID,
})

if err == nil {
return fmt.Errorf("cockpit source (%s) still exists", rs.Primary.ID)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func TestAccDataSourceContainer_HealthCheck(t *testing.T) {
func TestAccDataSourceContainer_ScalingOption(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
9 changes: 8 additions & 1 deletion internal/services/container/container_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
func TestAccContainer_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -135,6 +136,7 @@ func TestAccContainer_Basic(t *testing.T) {
func TestAccContainer_Env(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -278,6 +280,7 @@ func TestAccContainer_WithIMG(t *testing.T) {
func TestAccContainer_HTTPOption(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -334,6 +337,7 @@ func TestAccContainer_HTTPOption(t *testing.T) {
func TestAccContainer_Sandbox(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -404,6 +408,7 @@ func TestAccContainer_Sandbox(t *testing.T) {
func TestAccContainer_HealthCheck(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -458,6 +463,7 @@ func TestAccContainer_HealthCheck(t *testing.T) {
func TestAccContainer_ScalingOption(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -547,6 +553,7 @@ func TestAccContainer_ScalingOption(t *testing.T) {
func TestAccContainer_CommandAndArgs(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -629,6 +636,7 @@ func TestAccContainer_CommandAndArgs(t *testing.T) {
func TestAccContainer_PrivateNetwork(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -797,7 +805,6 @@ func isContainerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
ContainerID: id,
Region: region,
})

if err == nil {
return fmt.Errorf("container (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 0 additions & 1 deletion internal/services/container/cron_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ func isCronDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
CronID: id,
Region: region,
})

if err == nil {
return fmt.Errorf("containerSDK cron (%s) still exists", rs.Primary.ID)
}
Expand Down
2 changes: 0 additions & 2 deletions internal/services/container/namespace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ func isNamespaceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
NamespaceID: id,
Region: region,
})

if err == nil {
return fmt.Errorf("container namespace (%s) still exists", rs.Primary.ID)
}
Expand Down Expand Up @@ -394,7 +393,6 @@ func isRegistryDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
NamespaceID: rs.Primary.Attributes["registry_namespace_id"],
Region: region,
})

if err == nil {
return fmt.Errorf("registry namespace (%s) still exists", rs.Primary.Attributes["registry_namespace_id"])
}
Expand Down
1 change: 0 additions & 1 deletion internal/services/container/token_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ func isTokenDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
TokenID: id,
Region: region,
})

if err == nil {
return fmt.Errorf("container token (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 0 additions & 1 deletion internal/services/container/trigger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ func isTriggerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
TriggerID: id,
Region: region,
})

if err == nil {
return fmt.Errorf("container trigger (%s) still exists", rs.Primary.ID)
}
Expand Down
1 change: 1 addition & 0 deletions internal/services/domain/record_data_source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccDataSourceDomainRecord_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 0 additions & 1 deletion internal/services/domain/registration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ func testAccCheckDomainStatus(tt *acctest.TestTools, expectedAutoRenew, expected
domainResp, getErr := registrarAPI.GetDomain(&domainSDK.RegistrarAPIGetDomainRequest{
Domain: domainName,
})

if getErr != nil {
return fmt.Errorf("failed to get details for domain %s: %w", domainName, getErr)
}
Expand Down
2 changes: 2 additions & 0 deletions internal/services/edgeservices/backend_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesBackend_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -57,6 +58,7 @@ func TestAccEdgeServicesBackend_Basic(t *testing.T) {
func TestAccEdgeServicesBackend_LB(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/cache_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesCache_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/dns_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesDNS_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/pipeline_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesPipeline_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/plan_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesPlan_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/route_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesRoute_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/tls_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesTLS_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 1 addition & 0 deletions internal/services/edgeservices/waf_stage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccEdgeServicesWAF_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
1 change: 0 additions & 1 deletion internal/services/file/testfuncs/checks.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func CheckFileDestroy(tt *acctest.TestTools) resource.TestCheckFunc {
Region: region,
FilesystemID: id,
})

if err == nil {
return fmt.Errorf("filesystem (%s) still exists", rs.Primary.ID)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
func TestAccDataSourceFlexibleIP_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -47,6 +48,7 @@ func TestAccDataSourceFlexibleIP_Basic(t *testing.T) {
func TestAccDataSourceFlexibleIP_Multiple(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down Expand Up @@ -60,6 +61,7 @@ func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) {
func TestAccDataSourceFlexibleIPs_WithBaremetalIDs(t *testing.T) {
tt := acctest.NewTestTools(t)
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand Down
Loading
Loading