Skip to content

fix(tests): remove redundant region references in RDB and TEM tests #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(tests): remove redundant region references in RDB and TEM tests #3325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/services/rdb/read_replica_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ func TestAccReadReplica_DifferentZone(t *testing.T) {

resource "scaleway_rdb_read_replica" "different_zone" {
instance_id = scaleway_rdb_instance.different_zone.id
region = scaleway_rdb_instance.different_zone.region
private_network {
private_network_id = scaleway_vpc_private_network.different_zone.id
enable_ipam = true
Expand Down Expand Up @@ -440,7 +439,6 @@ func TestAccReadReplica_DifferentZone(t *testing.T) {

resource "scaleway_rdb_read_replica" "different_zone" {
instance_id = scaleway_rdb_instance.different_zone.id
region = scaleway_rdb_instance.different_zone.region
same_zone = true
private_network {
private_network_id = scaleway_vpc_private_network.different_zone.id
Expand Down Expand Up @@ -474,7 +472,6 @@ func TestAccReadReplica_DifferentZone(t *testing.T) {

resource "scaleway_rdb_read_replica" "different_zone" {
instance_id = scaleway_rdb_instance.different_zone.id
region = scaleway_rdb_instance.different_zone.region
same_zone = false
private_network {
private_network_id = scaleway_vpc_private_network.different_zone.id
Expand Down
1 change: 0 additions & 1 deletion internal/services/tem/blockedlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func TestAccBlockedList_Basic(t *testing.T) {

resource scaleway_tem_domain_validation valid {
domain_id = scaleway_tem_domain.cr01.id
region = scaleway_tem_domain.cr01.region
timeout = 3600
}

Expand Down
1 change: 0 additions & 1 deletion internal/services/tem/domain_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ func TestAccDataSourceDomain_Reputation(t *testing.T) {

resource "scaleway_tem_domain_validation" "valid" {
domain_id = scaleway_tem_domain.main.id
region = scaleway_tem_domain.main.region
timeout = 3600
}

Expand Down
1 change: 0 additions & 1 deletion internal/services/tem/domain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ func TestAccDomain_Autoconfig(t *testing.T) {

resource scaleway_tem_domain_validation valid {
domain_id = scaleway_tem_domain.cr01.id
region = scaleway_tem_domain.cr01.region
timeout = 3600
}

Expand Down
2 changes: 0 additions & 2 deletions internal/services/tem/domain_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ func TestAccDomainValidation_Validation(t *testing.T) {

resource scaleway_tem_domain_validation valid {
domain_id = scaleway_tem_domain.cr01.id
region = scaleway_tem_domain.cr01.region
timeout = 3600
}
`, domainNameValidation, subDomainName),
Expand Down Expand Up @@ -76,7 +75,6 @@ func TestAccDomainValidation_TimeoutError(t *testing.T) {

resource scaleway_tem_domain_validation valid {
domain_id = scaleway_tem_domain.cr01.id
region = scaleway_tem_domain.cr01.region
timeout = 1
}
`, domainNameValidation, subDomainName),
Expand Down
Loading