-
Notifications
You must be signed in to change notification settings - Fork 133
feat(audit_trail): add new data source audit_trail_event #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3445 +/- ##
=========================================
- Coverage 1.78% 1.77% -0.01%
=========================================
Files 401 403 +2
Lines 44084 44207 +123
=========================================
- Hits 786 784 -2
- Misses 43211 43335 +124
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. |
a2394cc to
fe22129
Compare
51a35a1 to
93bf6a6
Compare
93bf6a6 to
2f056d3
Compare
f5a6215 to
12845fc
Compare
0039116 to
982f867
Compare
defd74e to
a8b738e
Compare
| "product_name": { | ||
| Type: schema.TypeString, | ||
| Description: "Scaleway product associated with the listed events in a hyphenated format", | ||
| Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a list of those product somewhere? It could be helpful to provide hint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be no public list, and they're only pattern validated (no enum on sdk side).
I have contacted the team to see if they could add a list to their docs for those entries.
In the meantime I built a list from the sources and I included it in the .mds.
| }, | ||
| "service_name": { | ||
| Type: schema.TypeString, | ||
| Description: "Name of the service of the API call performed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a list of those service_name? It could be helpful to provide hinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be no public list, and they're only pattern validated (no enum on sdk side).
I have contacted the team to see if they could add a list to their docs for those entries.
In the meantime I built a list from the sources and I included it in the .mds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list is available from their ListProducts endpoint, however i'm not sure we'd want to add an API call in the Datasource function purely for informative value. Leaving it as is for now, let me know what you think!
| }, | ||
| { | ||
| PreConfig: func() { waitForAuditTrailEvents(t, ctx, auditTrailAPI, project) }, | ||
| Config: fmt.Sprintf(` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all this step are required? You could have a single event and then define several blocks of data resource and perform checks on each of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!! I have reworked the tests, should be better now :)
5060ec7 to
39f1c26
Compare
7908e83 to
a968a21
Compare
#3427