Skip to content

Conversation

@estellesoulard
Copy link
Contributor

@estellesoulard estellesoulard commented Nov 4, 2025

#3427

  • I had initially added some tests without any filters, but this led to a huge cassette with a lot of info (listing all events on a whole organization for the past hour). This is why I opted to always include a filter on the test project to limit this.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 0% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.77%. Comparing base (e70b788) to head (7793c6b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/audittrail/event_data_source.go 0.00% 114 Missing ⚠️
internal/services/audittrail/helpers.go 0.00% 6 Missing ⚠️
provider/sdkv2.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3445      +/-   ##
=========================================
- Coverage    1.78%   1.77%   -0.01%     
=========================================
  Files         401     403       +2     
  Lines       44084   44205     +121     
=========================================
- Hits          786     784       -2     
- Misses      43211   43333     +122     
- Partials       87      88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from a2394cc to fe22129 Compare November 4, 2025 11:12
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch 2 times, most recently from 51a35a1 to 93bf6a6 Compare November 5, 2025 15:11
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from 93bf6a6 to 2f056d3 Compare November 5, 2025 17:28
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from f5a6215 to 12845fc Compare November 6, 2025 13:32
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from 0039116 to 982f867 Compare November 7, 2025 16:04
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from defd74e to a8b738e Compare November 7, 2025 16:38
@estellesoulard estellesoulard marked this pull request as ready for review November 7, 2025 16:47
@estellesoulard estellesoulard marked this pull request as draft November 18, 2025 09:29
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch 4 times, most recently from 875627d to 6f717c3 Compare November 20, 2025 11:03
@estellesoulard estellesoulard force-pushed the feat/audit-trail-event-data-source branch from 6f717c3 to 0d4595d Compare November 20, 2025 11:12
@estellesoulard estellesoulard marked this pull request as ready for review November 20, 2025 12:08
@remyleone remyleone added this pull request to the merge queue Nov 21, 2025
Merged via the queue into master with commit 67cbd97 Nov 21, 2025
157 of 158 checks passed
@remyleone remyleone deleted the feat/audit-trail-event-data-source branch November 21, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants