Skip to content

chore: remove unused acctest.PreCheck #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

chore: remove unused acctest.PreCheck #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/acctest/acctest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ import (
"gopkg.in/dnaeon/go-vcr.v4/pkg/recorder"
)

func PreCheck(_ *testing.T) {}

type TestTools struct {
T *testing.T
Meta *meta.Meta
Expand Down
4 changes: 0 additions & 4 deletions internal/services/account/project_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ func TestAccDataSourceProject_Basic(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
isProjectDestroyed(tt),
Expand Down Expand Up @@ -61,7 +60,6 @@ func TestAccDataSourceProject_Default(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down Expand Up @@ -105,7 +103,6 @@ func TestAccDataSourceProject_Extract(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand All @@ -129,7 +126,6 @@ func TestAccDataSourceProject_List(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
isProjectDestroyed(tt),
Expand Down
4 changes: 0 additions & 4 deletions internal/services/applesilicon/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccServer_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: isServerDestroyed(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -70,7 +69,6 @@ func TestAccServer_EnableDisabledVPC(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: isServerDestroyed(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -125,7 +123,6 @@ func TestAccServer_EnableVPC(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: isServerDestroyed(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -270,7 +267,6 @@ func TestAccServer_Commitment(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: isServerDestroyed(tt),
Steps: []resource.TestStep{
Expand Down
1 change: 0 additions & 1 deletion internal/services/autoscaling/instance_group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccInstanceGroup_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: testAccCheckInstanceGroupDestroy(tt),
Steps: []resource.TestStep{
Expand Down
1 change: 0 additions & 1 deletion internal/services/autoscaling/instance_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccInstancePolicy_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: testAccCheckInstancePolicyDestroy(tt),
Steps: []resource.TestStep{
Expand Down
2 changes: 0 additions & 2 deletions internal/services/autoscaling/instance_template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccInstanceTemplate_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: testAccCheckInstanceTemplateDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -74,7 +73,6 @@ func TestAccInstanceTemplate_PrivateNetwork(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: testAccCheckInstanceTemplateDestroy(tt),
Steps: []resource.TestStep{
Expand Down
1 change: 0 additions & 1 deletion internal/services/az/availability_zones_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ func TestAccDataSourceAvailabilityZones_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down
3 changes: 0 additions & 3 deletions internal/services/baremetal/offer_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ func TestAccDataSourceOffer_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down Expand Up @@ -69,7 +68,6 @@ func TestAccDataSourceOffer_SubscriptionPeriodHourly(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down Expand Up @@ -119,7 +117,6 @@ func TestAccDataSourceOffer_SubscriptionPeriodMonthly(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down
1 change: 0 additions & 1 deletion internal/services/baremetal/option_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccDataSourceOption_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down
1 change: 0 additions & 1 deletion internal/services/baremetal/os_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func TestAccDataSourceOS_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down
6 changes: 0 additions & 6 deletions internal/services/baremetal/partition_schema_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ func TestAccPartitionSchemaDataSource_Basic(t *testing.T) {
serverName := "TestAccPartitionSchemaDataSource_Basic"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -97,7 +96,6 @@ func TestAccPartitionSchemaDataSource_WithoutExtraPart(t *testing.T) {
serverName := "TestAccPartitionSchemaDataSource_WithoutExtraPart"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -164,7 +162,6 @@ func TestAccPartitionSchemaDataSource_WithoutSwapAndExtraPart(t *testing.T) {
serverName := "TestAccPartitionSchemaDataSource_WithoutSwapAndExtraPart"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -231,7 +228,6 @@ func TestAccPartitionSchemaDataSource_WithAlternateOffer(t *testing.T) {
name := "TestAccPartitionSchemaDataSource_WithAlternateOffer"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -300,7 +296,6 @@ func TestAccPartitionSchemaDataSource_IncompatibleOS(t *testing.T) {
name := "TestAccPartitionSchemaDataSource_IncompatibleOS"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -362,7 +357,6 @@ func TestAccPartitionSchemaDataSource_IncompatibleOffer(t *testing.T) {
name := "TestAccPartitionSchemaDataSource_IncompatibleOffer"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down
1 change: 0 additions & 1 deletion internal/services/baremetal/server_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func TestAccDataSourceServer_Basic(t *testing.T) {
name := "TestAccScalewayDataSourceBaremetalServer_Basic"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down
13 changes: 0 additions & 13 deletions internal/services/baremetal/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func TestAccServer_Basic(t *testing.T) {
name := "TestAccServer_Basic"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -126,7 +125,6 @@ func TestAccServer_RequiredInstallConfig(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand All @@ -151,7 +149,6 @@ func TestAccServer_WithoutInstallConfig(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -191,7 +188,6 @@ func TestAccServer_CreateServerWithCustomInstallConfig(t *testing.T) {
name := "TestAccServer_CreateServerWithCustomInstallConfig"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -245,7 +241,6 @@ func TestAccServer_CreateServerWithServicePassword(t *testing.T) {
password := "HelloWorld678!"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -302,7 +297,6 @@ func TestAccServer_CreateServerWithOption(t *testing.T) {
name := "TestAccScalewayBaremetalServer_CreateServerWithOption"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -368,7 +362,6 @@ func TestAccServer_AddOption(t *testing.T) {
name := "TestAccScalewayBaremetalServer_AddOption"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -460,7 +453,6 @@ func TestAccServer_AddTwoOptionsThenDeleteOne(t *testing.T) {
name := "TestAccScalewayBaremetalServer_AddTwoOptionsThenDeleteOne"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: baremetalchecks.CheckServerDestroy(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -615,7 +607,6 @@ func TestAccServer_CreateServerWithPrivateNetwork(t *testing.T) {
name := "TestAccScalewayBaremetalServer_CreateServerWithPrivateNetwork"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -687,7 +678,6 @@ func TestAccServer_AddPrivateNetwork(t *testing.T) {
name := "TestAccScalewayBaremetalServer_AddPrivateNetwork"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -800,7 +790,6 @@ func TestAccServer_AddAnotherPrivateNetwork(t *testing.T) {
name := "TestAccScalewayBaremetalServer_AddAnotherPrivateNetwork"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -926,7 +915,6 @@ func TestAccServer_WithIPAMPrivateNetwork(t *testing.T) {
name := "TestAccScalewayBaremetalServer_WithIPAMPrivateNetwork"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down Expand Up @@ -1105,7 +1093,6 @@ func TestAccServer_UpdateSubscriptionPeriod(t *testing.T) {
}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
baremetalchecks.CheckServerDestroy(tt),
Expand Down
1 change: 0 additions & 1 deletion internal/services/billing/consumption_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ func TestAccDataSourceConsumption_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down
1 change: 0 additions & 1 deletion internal/services/billing/invoices_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ func TestAccDataSourceInvoices_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
Steps: []resource.TestStep{
{
Expand Down
1 change: 0 additions & 1 deletion internal/services/block/snapshot_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ func TestAccDataSourceSnapshot_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
blocktestfuncs.IsSnapshotDestroyed(tt),
Expand Down
3 changes: 0 additions & 3 deletions internal/services/block/snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ func TestAccSnapshot_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: blocktestfuncs.IsSnapshotDestroyed(tt),
Steps: []resource.TestStep{
Expand Down Expand Up @@ -48,7 +47,6 @@ func TestAccSnapshot_FromS3(t *testing.T) {

bucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-block-snapshot")
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
blocktestfuncs.IsSnapshotDestroyed(tt),
Expand Down Expand Up @@ -92,7 +90,6 @@ func TestAccSnapshot_ToS3(t *testing.T) {

bucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-export-block-snapshot")
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
blocktestfuncs.IsSnapshotDestroyed(tt),
Expand Down
1 change: 0 additions & 1 deletion internal/services/block/volume_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ func TestAccDataSourceVolume_Basic(t *testing.T) {
defer tt.Cleanup()

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ProtoV6ProviderFactories: tt.ProviderFactories,
CheckDestroy: resource.ComposeTestCheckFunc(
blocktestfuncs.IsVolumeDestroyed(tt),
Expand Down
Loading
Loading