Skip to content

test(container): fix flaky tests #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

test(container): fix flaky tests #3451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c528487
test(container): update http-option cassette with vpc interactions
jremy42 Nov 6, 2025
e4dea2c
TestAccContainer_PrivateNetwork: avoid PN mix-ups
Mia-Cross Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 53 additions & 61 deletions internal/services/container/container_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,32 +643,28 @@ func TestAccContainer_PrivateNetwork(t *testing.T) {
name = "TestAccContainer_PrivateNetwork"
}

resource scaleway_vpc_private_network pn00 {
name = "test-acc-container-pn-pn00"
vpc_id = scaleway_vpc.main.id
}
resource scaleway_vpc_private_network pn01 {
name = "test-acc-container-pn-pn01"
resource scaleway_vpc_private_network start {
name = "test-acc-container-pn-start"
vpc_id = scaleway_vpc.main.id
}

resource scaleway_container_namespace main {
activate_vpc_integration = true
}

resource scaleway_container c00 {
name = "test-acc-container-pn-c00"
resource scaleway_container to_stay {
name = "test-acc-container-pn-to-stay"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn00.id
private_network_id = scaleway_vpc_private_network.start.id
sandbox = "v1"
tags = [ "c00" ]
tags = [ "to-stay" ]
}
`,
Check: resource.ComposeTestCheckFunc(
isContainerPresent(tt, "scaleway_container.c00"),
isContainerPresent(tt, "scaleway_container.to_stay"),
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "activate_vpc_integration", "true"),
resource.TestCheckResourceAttr("scaleway_container.c00", "sandbox", "v1"),
resource.TestCheckResourceAttrPair("scaleway_container.c00", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
resource.TestCheckResourceAttr("scaleway_container.to_stay", "sandbox", "v1"),
resource.TestCheckResourceAttrPair("scaleway_container.to_stay", "private_network_id", "scaleway_vpc_private_network.start", "id"),
),
},
{
Expand All @@ -677,53 +673,49 @@ func TestAccContainer_PrivateNetwork(t *testing.T) {
name = "TestAccContainer_PrivateNetwork"
}

resource scaleway_vpc_private_network pn00 {
name = "test-acc-container-pn-pn00"
vpc_id = scaleway_vpc.main.id
}
resource scaleway_vpc_private_network pn01 {
name = "test-acc-container-pn-pn01"
resource scaleway_vpc_private_network start {
name = "test-acc-container-pn-start"
vpc_id = scaleway_vpc.main.id
}

resource scaleway_container_namespace main {
activate_vpc_integration = true
}

resource scaleway_container c00 {
name = "test-acc-container-pn-c00"
resource scaleway_container to_stay {
name = "test-acc-container-pn-to-stay"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn00.id
private_network_id = scaleway_vpc_private_network.start.id
sandbox = "v1"
tags = [ "c00" ]
tags = [ "to-stay" ]
}

resource scaleway_container c01 {
name = "test-acc-container-pn-c01"
resource scaleway_container to_change {
name = "test-acc-container-pn-to-change"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn00.id
private_network_id = scaleway_vpc_private_network.start.id
sandbox = "v1"
tags = [ "c01" ]
tags = [ "to-change" ]
}

resource scaleway_container c02 {
name = "test-acc-container-pn-c02"
resource scaleway_container to_remove {
name = "test-acc-container-pn-to-remove"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn00.id
private_network_id = scaleway_vpc_private_network.start.id
sandbox = "v1"
tags = [ "c02" ]
tags = [ "to-remove" ]
}
`,
Check: resource.ComposeTestCheckFunc(
isContainerPresent(tt, "scaleway_container.c00"),
isContainerPresent(tt, "scaleway_container.c01"),
isContainerPresent(tt, "scaleway_container.c02"),
resource.TestCheckResourceAttr("scaleway_container.c00", "sandbox", "v1"),
resource.TestCheckResourceAttr("scaleway_container.c01", "sandbox", "v1"),
resource.TestCheckResourceAttr("scaleway_container.c02", "sandbox", "v1"),
resource.TestCheckResourceAttrPair("scaleway_container.c00", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.c01", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.c02", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
isContainerPresent(tt, "scaleway_container.to_stay"),
isContainerPresent(tt, "scaleway_container.to_change"),
isContainerPresent(tt, "scaleway_container.to_remove"),
resource.TestCheckResourceAttr("scaleway_container.to_stay", "sandbox", "v1"),
resource.TestCheckResourceAttr("scaleway_container.to_change", "sandbox", "v1"),
resource.TestCheckResourceAttr("scaleway_container.to_remove", "sandbox", "v1"),
resource.TestCheckResourceAttrPair("scaleway_container.to_stay", "private_network_id", "scaleway_vpc_private_network.start", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.to_change", "private_network_id", "scaleway_vpc_private_network.start", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.to_remove", "private_network_id", "scaleway_vpc_private_network.start", "id"),
),
},
{
Expand All @@ -732,50 +724,50 @@ func TestAccContainer_PrivateNetwork(t *testing.T) {
name = "TestAccContainer_PrivateNetwork"
}

resource scaleway_vpc_private_network pn00 {
name = "test-acc-container-pn-pn00"
resource scaleway_vpc_private_network start {
name = "test-acc-container-pn-start"
vpc_id = scaleway_vpc.main.id
}

resource scaleway_vpc_private_network pn01 {
name = "test-acc-container-pn-pn01"
resource scaleway_vpc_private_network new {
name = "test-acc-container-pn-new"
vpc_id = scaleway_vpc.main.id
}

resource scaleway_container_namespace main {
activate_vpc_integration = true
}

resource scaleway_container c00 {
name = "test-acc-container-pn-c00"
resource scaleway_container to_stay {
name = "test-acc-container-pn-to-stay"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.start.id
sandbox = "v1"
tags = [ "c00" ]
tags = [ "to-stay" ]
}

resource scaleway_container c01 {
name = "test-acc-container-pn-c01"
resource scaleway_container to_change {
name = "test-acc-container-pn-to-change"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn01.id
private_network_id = scaleway_vpc_private_network.new.id
sandbox = "v1"
tags = [ "c01" ]
tags = [ "to-change" ]
}

resource scaleway_container c02 {
name = "test-acc-container-pn-c02"
resource scaleway_container to_remove {
name = "test-acc-container-pn-to-remove"
namespace_id = scaleway_container_namespace.main.id
private_network_id = scaleway_vpc_private_network.pn00.id
sandbox = "v1"
tags = [ "c02" ]
tags = [ "to-remove" ]
}
`,
Check: resource.ComposeTestCheckFunc(
isContainerPresent(tt, "scaleway_container.c00"),
isContainerPresent(tt, "scaleway_container.c01"),
isContainerPresent(tt, "scaleway_container.c02"),
resource.TestCheckResourceAttr("scaleway_container.c00", "private_network_id", ""),
resource.TestCheckResourceAttrPair("scaleway_container.c01", "private_network_id", "scaleway_vpc_private_network.pn01", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.c02", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
isContainerPresent(tt, "scaleway_container.to_stay"),
isContainerPresent(tt, "scaleway_container.to_change"),
isContainerPresent(tt, "scaleway_container.to_remove"),
resource.TestCheckResourceAttrPair("scaleway_container.to_stay", "private_network_id", "scaleway_vpc_private_network.start", "id"),
resource.TestCheckResourceAttrPair("scaleway_container.to_change", "private_network_id", "scaleway_vpc_private_network.new", "id"),
resource.TestCheckResourceAttr("scaleway_container.to_remove", "private_network_id", ""),
),
},
},
Expand Down
Loading
Loading