Skip to content

fix(SelectInput): click oustide should work and size fix #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
+30 −1
Open

fix(SelectInput): click oustide should work and size fix #5491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/sharp-steaks-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ultraviolet/ui": patch
---

`SelectInput`:
- click outside should work in every context
- fix placeholder alignment when small
23 changes: 23 additions & 0 deletions packages/ui/src/components/SelectInput/components/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,29 @@ export const Dropdown = ({
)
const modalContext = useContext(ModalContext)

const handleClickOutside = useCallback(
(event: MouseEvent) => {
if (
event.target instanceof Node &&
ref.current &&
!ref.current.contains(event.target) &&
refSelect.current &&
!refSelect.current.contains(event.target)
) {
setIsDropdownVisible(false)
}
},
[setIsDropdownVisible, refSelect],
)

useEffect(() => {
document.addEventListener('mouseup', handleClickOutside)

return () => {
document.removeEventListener('mouseup', handleClickOutside)
}
}, [handleClickOutside])

Comment on lines +642 to +664
Copy link
Contributor

@matthprost matthprost Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already handled into the popup component it makes a duplicate. Maybe the issue is related to popup?

Copy link
Member

@DorianMaliszewski DorianMaliszewski Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lisalupi WDYT about that ? I agree with matthprost It should already be handled by the Popup component 🤔

Copy link
Collaborator Author

@lisalupi lisalupi Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I will go back to this pr once I am done with vanilla extract ^^

useEffect(() => {
if (refSelect.current && isDropdownVisible) {
const position =
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components/SelectInput/components/SelectBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ type DisplayValuesProps = {
refPlusTag: RefObject<HTMLDivElement | null>
displayShadowCopy?: boolean
}

const DisplayValues = ({
refTag,
nonOverflowedValues,
Expand Down
Loading