Skip to content

fix(TagList): overflow#6271

Merged
lisalupi merged 2 commits intomainfrom
fix/tag-list-width-overflow
Mar 30, 2026
Merged

fix(TagList): overflow#6271
lisalupi merged 2 commits intomainfrom
fix/tag-list-width-overflow

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

TagList: overflow can dynamically adapt to the container width.

⚠️ In order to do that, visually hidden div containing the tags is added. Be careful as it can break some tests. A data-testid has been added to overcome this issue.

@lisalupi lisalupi requested review from a team and chambo-e March 25, 2026 14:43
@lisalupi lisalupi self-assigned this Mar 25, 2026
@lisalupi lisalupi requested review from etienne-scaleway and vincentaudebert and removed request for a team March 25, 2026 14:43
@lisalupi lisalupi added the bug Something isn't working label Mar 25, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: b9ad610

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.64%. Comparing base (adf8a65) to head (b9ad610).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6271      +/-   ##
==========================================
+ Coverage   92.57%   92.64%   +0.07%     
==========================================
  Files         533      533              
  Lines        9981     9984       +3     
  Branches     3805     3780      -25     
==========================================
+ Hits         9240     9250      +10     
+ Misses        677      670       -7     
  Partials       64       64              
Files with missing lines Coverage Δ
packages/ui/src/components/Popup/styles.css.ts 100.00% <ø> (ø)
packages/ui/src/components/TagList/constant.ts 100.00% <100.00%> (ø)
packages/ui/src/components/TagList/index.tsx 95.23% <100.00%> (+0.04%) ⬆️
packages/ui/src/components/TagList/styles.css.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53022de...b9ad610. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: should we fully hide tag list and only show popover when the parent width is really small (not sure if we will ever have this use case) ?

Image

@lisalupi lisalupi force-pushed the fix/tag-list-width-overflow branch from 2e8ba22 to dbedf1c Compare March 27, 2026 15:10
Copy link
Copy Markdown
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🤩

@lisalupi lisalupi merged commit 060b940 into main Mar 30, 2026
15 checks passed
@lisalupi lisalupi deleted the fix/tag-list-width-overflow branch March 30, 2026 08:08
@scaleway-bot scaleway-bot mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants