test cases for complete and abort mpu helper functions in gcpservice unit tests

Author: benzekrimaha

tests/unit/storage/data/external/GcpService.spec.js

@@ -3,6 +3,7 @@ const http = require('http');
 const { GCP } = require('../../../../../lib/storage/data/external/GCP');
 const { ListObjectsCommand, ListObjectVersionsCommand } = require('@aws-sdk/client-s3');
 const MpuHelper = require('../../../../../lib/storage/data/external/GCP/GcpApis/mpuHelper');
+const { createMpuKey } = require('../../../../../lib/storage/data/external/GCP/GcpUtils');
 
 const httpPort = 8888;
 
@@ -495,6 +496,153 @@ describe('GcpService helper behavior', () => {
 });
 
 describe('GcpService mpu helper behavior', () => {
+    let client;
+
+    beforeEach(() => {
+        client = new GCP({
+            s3Params: {
+                endpoint: 'http://localhost',
+                maxAttempts: 1,
+                forcePathStyle: true,
+                region: 'us-east-1',
+                credentials: {
+                    accessKeyId: 'access',
+                    secretAccessKey: 'secret',
+                },
+            },
+            bucketName: 'unit-bucket',
+            dataStoreName: 'unit-location',
+        });
+    });
+
+    afterEach(() => {
+        jest.restoreAllMocks();
+    });
+
+    it('abortMultipartUpload should reject missing parameters', done => {
+        client.abortMultipartUpload({ Bucket: 'b' }, err => {
+            assert(err);
+            assert(err.is.InvalidRequest);
+            done();
+        });
+    });
+
+    it('abortMultipartUpload should call removeParts with derived Prefix', done => {
+        const removeSpy = jest.spyOn(MpuHelper.prototype, 'removeParts')
+            .mockImplementation((_delParams, cb) => cb(null));
+
+        const params = {
+            Bucket: 'b',
+            MPU: 'mpu-b',
+            Key: 'obj',
+            UploadId: 'upload',
+        };
+
+        client.abortMultipartUpload(params, err => {
+            assert.ifError(err);
+            expect(removeSpy).toHaveBeenCalledTimes(1);
+            expect(removeSpy).toHaveBeenCalledWith({
+                Bucket: params.Bucket,
+                MPU: params.MPU,
+                Prefix: createMpuKey(params.Key, params.UploadId),
+            }, expect.any(Function));
+            done();
+        });
+    });
+
+    it('completeMultipartUpload should reject missing parameters', done => {
+        client.completeMultipartUpload({ Bucket: 'b' }, err => {
+            assert(err);
+            assert(err.is.InvalidRequest);
+            done();
+        });
+    });
+
+    it('completeMultipartUpload should reject empty parts list', done => {
+        client.completeMultipartUpload({
+            Bucket: 'b',
+            MPU: 'mpu-b',
+            Key: 'obj',
+            UploadId: 'upload',
+            MultipartUpload: { Parts: [] },
+        }, err => {
+            assert(err);
+            assert(err.is.InvalidRequest);
+            done();
+        });
+    });
+
+    it('completeMultipartUpload should reject invalid part order', done => {
+        client.completeMultipartUpload({
+            Bucket: 'b',
+            MPU: 'mpu-b',
+            Key: 'obj',
+            UploadId: 'upload',
+            MultipartUpload: {
+                Parts: [
+                    { PartNumber: 2 },
+                    { PartNumber: 1 },
+                ],
+            },
+        }, err => {
+            assert(err);
+            assert.strictEqual(err.message, 'InvalidPartOrder');
+            done();
+        });
+    });
+
+    it('completeMultipartUpload should run MPU flow and remove parts', done => {
+        jest.spyOn(console, 'log').mockImplementation(() => undefined);
+
+        const splitMergeSpy = jest.spyOn(MpuHelper.prototype, 'splitMerge')
+            .mockImplementation((params, partList, level, cb) => cb(null, 2));
+        const composeFinalSpy = jest.spyOn(MpuHelper.prototype, 'composeFinal')
+            .mockImplementation((numParts, params, cb) => cb(null, 'finalKey'));
+        const generateSpy = jest.spyOn(MpuHelper.prototype, 'generateMpuResult')
+            .mockImplementation((result, partList, cb) => cb(null, result, 'aggEtag'));
+        const copySpy = jest.spyOn(MpuHelper.prototype, 'copyToMain')
+            .mockImplementation((result, aggregateETag, params, cb) => cb(null, {
+                Bucket: params.Bucket,
+                Key: params.Key,
+                VersionId: 'v1',
+                ETag: '"aggEtag"',
+            }));
+        const removeSpy = jest.spyOn(MpuHelper.prototype, 'removeParts')
+            .mockImplementation((_delParams, cb) => cb(null));
+
+        const params = {
+            Bucket: 'b',
+            MPU: 'mpu-b',
+            Key: 'obj',
+            UploadId: 'upload',
+            MultipartUpload: {
+                Parts: [
+                    { PartNumber: 1 },
+                    { PartNumber: 2 },
+                ],
+            },
+        };
+
+        client.completeMultipartUpload(params, (err, res) => {
+            assert.ifError(err);
+            assert(res);
+            assert.strictEqual(res.Bucket, params.Bucket);
+            assert.strictEqual(res.Key, params.Key);
+
+            expect(splitMergeSpy).toHaveBeenCalledTimes(1);
+            expect(composeFinalSpy).toHaveBeenCalledTimes(1);
+            expect(generateSpy).toHaveBeenCalledTimes(1);
+            expect(copySpy).toHaveBeenCalledTimes(1);
+            expect(removeSpy).toHaveBeenCalledTimes(1);
+            expect(removeSpy).toHaveBeenCalledWith({
+                Bucket: params.Bucket,
+                MPU: params.MPU,
+                Prefix: createMpuKey(params.Key, params.UploadId),
+            }, expect.any(Function));
+            done();
+        });
+    });
+
     describe('removeParts', () => {
         it('should list versions via send(ListObjectVersionsCommand) and delete each version', done => {
             const service = {