-
Notifications
You must be signed in to change notification settings - Fork 20
adding content length to avoid the warning on put commands #2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding content length to avoid the warning on put commands #2586
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
n aws sdk v2 we were able to call putObject with a stream body without explicitly providing the ContentLength; the sdk handled this more loosely and didn’t complain.In v3 the S3 client is stricter and surfaces a warning when we send a stream of unknown length to putObject. To avoid this warning we now provide it in the request. Issue: ARSN-526
80a241d to
c98a22d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.3 #2586 +/- ##
================================================
Coverage 72.72% 72.72%
================================================
Files 221 221
Lines 18070 18070
Branches 3737 3737
================================================
Hits 13142 13142
Misses 4923 4923
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francoisferrand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix all such warnings, or only part of them?
Issue: ARSN-526
3a12ae1 to
308bb4a
Compare
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-526. Goodbye benzekrimaha. The following options are set: approve |
Issue: ARSN-526