Skip to content

Support the new API GetObjectAttributes #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maeldonn wants to merge 2 commits into
base: development/8.2
Choose a base branch
from
Open

Support the new API GetObjectAttributes #2588

maeldonn wants to merge 2 commits into from
+5 −1

Conversation

@maeldonn
Copy link

@maeldonn maeldonn commented Jan 26, 2026

Issue: ARSN-549

@maeldonn maeldonn requested review from a team, DarkIsDude, Copilot and delthas January 26, 2026 08:59
@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.44

  • 8.3.0

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the AWS S3 GetObjectAttributes API by introducing routing logic, action mappings, and incrementing the package version.

Changes:

  • Added routing for the objectGetAttributes API method triggered by the attributes query parameter
  • Added action mappings for objectGetAttributes in both policy evaluation and monitoring maps
  • Incremented package version from 8.2.43 to 8.2.44

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Bumped version to 8.2.44 for the new API support
lib/s3routes/routes/routeGET.ts Added routing logic to handle query.attributes parameter and call objectGetAttributes
lib/policyEvaluator/utils/actionMaps.ts Added objectGetAttributes to both sharedActionMap and actionMonitoringMapS3 for IAM policy evaluation and monitoring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/policyEvaluator/utils/actionMaps.ts
objectGetLegalHold: 'GetObjectLegalHold',
objectGetRetention: 'GetObjectRetention',
objectGetTagging: 'GetObjectTagging',
objectGetAttributes: 's3:GetObjectAttributes',
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value in actionMonitoringMapS3 should be 'GetObjectAttributes' not 's3:GetObjectAttributes'. All other entries in this map use plain action names without the 's3:' prefix (see lines 160-164, 166-173 for examples like 'GetObject', 'GetObjectAcl', 'GetObjectLegalHold', etc.).

Suggested change
objectGetAttributes: 's3:GetObjectAttributes',
objectGetAttributes: 'GetObjectAttributes',

Copilot uses AI. Check for mistakes.
lib/s3routes/routes/routeGET.ts
Comment on lines +86 to +87
} else if (query.attributes !== undefined) {
call('objectGetAttributes');
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test case for the new objectGetAttributes routing logic. The existing test file has test cases for other query parameters like objectGetACL (line 81-91), and following the established pattern, there should be a test to verify that when query.attributes is present, the router calls 'objectGetAttributes'.

Copilot uses AI. Check for mistakes.
DarkIsDude
DarkIsDude reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@DarkIsDude DarkIsDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a lot to add, IA spotted them

@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.44

  • 8.3.1

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

delthas
delthas approved these changes Jan 26, 2026
View reviewed changes
Copy link

@delthas delthas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from AI comments

francoisferrand
francoisferrand reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from Copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francoisferrand francoisferrand francoisferrand left review comments

@DarkIsDude DarkIsDude DarkIsDude left review comments

Copilot code review Copilot Copilot left review comments

@delthas delthas delthas approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maeldonn @bert-e @delthas @francoisferrand @DarkIsDude