-
Notifications
You must be signed in to change notification settings - Fork 2
(PTFE-2534) Remove sort and modify test assertion #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PTFE-2534) Remove sort and modify test assertion #255
Conversation
134e514 to
cee9700
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 88.92% 89.02% +0.09%
==========================================
Files 75 75
Lines 10044 10053 +9
==========================================
+ Hits 8932 8950 +18
+ Misses 1112 1103 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7621191 to
cc486ef
Compare
cc486ef to
99f6f0c
Compare
tcarmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as it is, but it's hard for me to understand what exactly did you fix, or is it just an improvement? If you are fixing something you could add a higher level test case that did not pass before and would pass now that'd be helpful.
It was an extra test to make sure we cover an hybrid case and a rework of what we fixed in emergency mode last time |
ok thanks for the extra context, then I think it's fine as it is 👍 |
99f6f0c to
a17b81d
Compare
Purpose