Skip to content

Conversation

@matthiasL-scality
Copy link
Contributor

Purpose

  • Remove wrong assert to be iso with other sort
  • Add one .0 to test mixed_versions with 10.0

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner July 16, 2025 13:41
@matthiasL-scality matthiasL-scality force-pushed the PTFE-2534-remove-sort-and-modify-test branch from 134e514 to cee9700 Compare July 17, 2025 07:53
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (12e203f) to head (a17b81d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   88.92%   89.02%   +0.09%     
==========================================
  Files          75       75              
  Lines       10044    10053       +9     
==========================================
+ Hits         8932     8950      +18     
+ Misses       1112     1103       -9     
Flag Coverage Δ
integration 87.47% <95.45%> (+0.11%) ⬆️
tests 87.44% <95.45%> (+0.10%) ⬆️
tests-BuildFailedTest 26.98% <4.54%> (?)
tests-QuickTest 34.11% <95.45%> (+0.07%) ⬆️
tests-RepositoryTests 26.64% <4.54%> (?)
tests-TaskQueueTests 51.95% <90.90%> (+0.04%) ⬆️
tests-TestBertE 66.12% <90.90%> (+0.02%) ⬆️
tests-TestQueueing 53.85% <90.90%> (+0.05%) ⬆️
tests-api-mock 16.15% <0.00%> (-0.02%) ⬇️
tests-noqueue 77.84% <95.45%> (+0.13%) ⬆️
tests-noqueue-BuildFailedTest 26.98% <4.54%> (?)
tests-noqueue-QuickTest 34.11% <95.45%> (+0.07%) ⬆️
tests-noqueue-RepositoryTests 26.64% <4.54%> (-0.02%) ⬇️
tests-noqueue-TaskQueueTests 51.95% <90.90%> (+0.04%) ⬆️
tests-noqueue-TestBertE 62.50% <90.90%> (+0.02%) ⬆️
tests-noqueue-TestQueueing 26.66% <4.54%> (?)
tests-server 29.68% <3.84%> (-0.02%) ⬇️
unittests 40.78% <100.00%> (+0.04%) ⬆️
utests 24.66% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2534-remove-sort-and-modify-test branch from 7621191 to cc486ef Compare July 17, 2025 15:20
@matthiasL-scality matthiasL-scality force-pushed the PTFE-2534-remove-sort-and-modify-test branch from cc486ef to 99f6f0c Compare July 18, 2025 08:24
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it is, but it's hard for me to understand what exactly did you fix, or is it just an improvement? If you are fixing something you could add a higher level test case that did not pass before and would pass now that'd be helpful.

@charlesprost
Copy link
Contributor

LGTM as it is, but it's hard for me to understand what exactly did you fix, or is it just an improvement? If you are fixing something you could add a higher level test case that did not pass before and would pass now that'd be helpful.

It was an extra test to make sure we cover an hybrid case and a rework of what we fixed in emergency mode last time

@tcarmet
Copy link
Contributor

tcarmet commented Jul 18, 2025

LGTM as it is, but it's hard for me to understand what exactly did you fix, or is it just an improvement? If you are fixing something you could add a higher level test case that did not pass before and would pass now that'd be helpful.

It was an extra test to make sure we cover an hybrid case and a rework of what we fixed in emergency mode last time

ok thanks for the extra context, then I think it's fine as it is 👍

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2534-remove-sort-and-modify-test branch from 99f6f0c to a17b81d Compare July 21, 2025 06:17
@matthiasL-scality matthiasL-scality merged commit 0fca76b into main Jul 21, 2025
18 checks passed
@matthiasL-scality matthiasL-scality deleted the PTFE-2534-remove-sort-and-modify-test branch July 21, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants