-
Notifications
You must be signed in to change notification settings - Fork 2
(PTFE-2638) Consider a skipped conclusion as success #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 89.02% 89.03%
=======================================
Files 75 75
Lines 10053 10060 +7
=======================================
+ Hits 8950 8957 +7
Misses 1103 1103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charlesprost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure @tcarmet approves it first
tcarmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime code LGTM, I think that's it. But I'm having some trouble with the test scenario. It would help to split the problem and create a new particular test with the scenario we are trying to fix.
41f5e69 to
8765097
Compare
8765097 to
a5258a8
Compare
charlesprost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure @tcarmet approves it first
tcarmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you for the changes and the extra test.
Purpose
Added status skipped for considering workflow skipped. If a workflow is skipped it will be consider has a success