Skip to content

Conversation

@matthiasL-scality
Copy link
Contributor

Purpose

Added status skipped for considering workflow skipped. If a workflow is skipped it will be consider has a success

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner November 6, 2025 13:07
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.03%. Comparing base (0fca76b) to head (a5258a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   89.02%   89.03%           
=======================================
  Files          75       75           
  Lines       10053    10060    +7     
=======================================
+ Hits         8950     8957    +7     
  Misses       1103     1103           
Flag Coverage Δ
integration 87.47% <ø> (ø)
tests 87.44% <ø> (ø)
tests-BuildFailedTest 26.98% <ø> (ø)
tests-QuickTest 34.11% <ø> (ø)
tests-RepositoryTests 26.64% <ø> (ø)
tests-TaskQueueTests 51.95% <ø> (ø)
tests-TestBertE 66.12% <ø> (ø)
tests-TestQueueing 53.85% <ø> (ø)
tests-api-mock 16.14% <0.00%> (-0.02%) ⬇️
tests-noqueue 77.84% <ø> (ø)
tests-noqueue-BuildFailedTest 26.98% <ø> (ø)
tests-noqueue-QuickTest 34.11% <ø> (ø)
tests-noqueue-RepositoryTests 26.64% <ø> (ø)
tests-noqueue-TaskQueueTests 51.95% <ø> (ø)
tests-noqueue-TestBertE 62.50% <ø> (+0.01%) ⬆️
tests-noqueue-TestQueueing 26.66% <ø> (ø)
tests-server 29.66% <0.00%> (-0.03%) ⬇️
unittests 40.82% <100.00%> (+0.04%) ⬆️
utests 24.71% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@charlesprost charlesprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure @tcarmet approves it first

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime code LGTM, I think that's it. But I'm having some trouble with the test scenario. It would help to split the problem and create a new particular test with the scenario we are trying to fix.

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2638-bert-e-workflow-failure branch from 41f5e69 to 8765097 Compare November 10, 2025 06:48
@matthiasL-scality matthiasL-scality force-pushed the PTFE-2638-bert-e-workflow-failure branch from 8765097 to a5258a8 Compare November 10, 2025 06:52
Copy link
Contributor

@charlesprost charlesprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure @tcarmet approves it first

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you for the changes and the extra test.

@matthiasL-scality matthiasL-scality merged commit 5a1c676 into main Nov 12, 2025
18 checks passed
@matthiasL-scality matthiasL-scality deleted the PTFE-2638-bert-e-workflow-failure branch November 12, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants