Feature/cldsrv 775 support service user #5995
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unter_config_cache CLDSRV-767: Add counter and cached config storage
…it_config_loading CLDSRV-770: parseRateLimitConfig unit tests
…it_redis_client_wrapper impr(CLDSRV-771): Rate limit client wrapper for redis
Add support for partial ARN prefix matching in isRateLimitServiceUser to allow more flexible configuration options: - Full ARN match: Exact user verification - Account-only match: Any user from management account - Path prefix match: Any user under specific path This allows operators to configure rate limiting with different levels of specificity while maintaining security through timing-safe comparisons. Example configurations: serviceUserArn: "arn:aws:iam::000000000000" (account only) serviceUserArn: "arn:aws:iam::000000000000:user/scality-internal/service-s3-ratelimit" (specific user)
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
anurag4DSB
force-pushed
the
feature/CLDSRV-775-support-service-user
branch
from
c128c7c to
cae7745
Compare
tmacro
force-pushed
the
improvement/CLDSRV-766/bucket_rate_limiting
branch
from
6f489d3 to
7b65049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Description
Motivation and context
Why is this change required? What problem does it solve?
Related issues
Please use the following link syntaxes #600 to reference issues in the
current repository
Checklist
Add tests to cover the changes
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
Sign your work
In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work
Thank you again for contributing! We will try to test and integrate the change
as soon as we can.