-
Notifications
You must be signed in to change notification settings - Fork 254
CLDSRV-807: add rate limit fields to server access logs (as optional fields) #6023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-807: add rate limit fields to server access logs (as optional fields) #6023
Conversation
Hello anurag4dsb,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
ping |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## development/9.2 #6023 +/- ##
===================================================
+ Coverage 84.56% 84.58% +0.01%
===================================================
Files 204 204
Lines 12907 12913 +6
===================================================
+ Hits 10915 10922 +7
+ Misses 1992 1991 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c88f7d4 to
3cbb5a8
Compare
|
rebased, squashed, added package.json bump and pushed. |
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-807. Goodbye anurag4dsb. The following options are set: approve |
Add rate limit fields to server access logs.
The fields are added only when a request is rate-limited. The normal CS logs follow the same pattern.
Fields Added:
rateLimited (boolean)rateLimitSource (string, enum: ["global", "bucket"])Note: We will run tests in the Integration repo where we are going to validate the rate-limiting requests feature under load.