Skip to content

Conversation

@anurag4DSB
Copy link
Contributor

@anurag4DSB anurag4DSB commented Dec 9, 2025

Add rate limit fields to server access logs.
The fields are added only when a request is rate-limited. The normal CS logs follow the same pattern.

Fields Added:

  1. rateLimited (boolean)
  • Value: true when request is rate-limited
  • Sparse: Field is absent (not false) when request is not rate-limited
  1. rateLimitSource (string, enum: ["global", "bucket"])
  • "global": Rate limited by default bucket-level configuration
  • "bucket": Rate limited by bucket-specific rate limit configuration
  • Sparse: Field is absent (not null) when request is not rate-limited

Note: We will run tests in the Integration repo where we are going to validate the rate-limiting requests feature under load.

@bert-e
Copy link
Contributor

bert-e commented Dec 9, 2025

Hello anurag4dsb,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 9, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-807 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.7

Please check the Fix Version/s of CLDSRV-807, or the target
branch of this pull request.

@anurag4DSB
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Dec 9, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@anurag4DSB anurag4DSB marked this pull request as ready for review December 9, 2025 13:29
@anurag4DSB anurag4DSB changed the title Improvement/cldsrv 807 add rate limit fields to server access logs CLDSRV-807: add rate limit fields to server access logs (as optional fields) Dec 9, 2025
@anurag4DSB anurag4DSB requested review from a team and leif-scality December 9, 2025 13:31
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.58%. Comparing base (f756789) to head (3cbb5a8).
⚠️ Report is 3 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 92.40% <100.00%> (+0.09%) ⬆️
lib/metadata/metadataUtils.js 93.93% <100.00%> (+0.11%) ⬆️
lib/utilities/serverAccessLogger.js 76.47% <ø> (ø)

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6023      +/-   ##
===================================================
+ Coverage            84.56%   84.58%   +0.01%     
===================================================
  Files                  204      204              
  Lines                12907    12913       +6     
===================================================
+ Hits                 10915    10922       +7     
+ Misses                1992     1991       -1     
Flag Coverage Δ
ceph-backend-test 66.46% <100.00%> (+0.03%) ⬆️
file-ft-tests 67.81% <100.00%> (+0.01%) ⬆️
kmip-ft-tests 28.16% <0.00%> (-0.02%) ⬇️
mongo-v0-ft-tests 69.06% <100.00%> (+0.01%) ⬆️
mongo-v1-ft-tests 69.07% <100.00%> (+0.04%) ⬆️
multiple-backend 35.34% <0.00%> (-0.02%) ⬇️
sur-tests 35.69% <0.00%> (-0.80%) ⬇️
sur-tests-inflights 37.48% <0.00%> (-0.05%) ⬇️
unit 69.89% <0.00%> (-0.04%) ⬇️
utapi-v2-tests 34.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anurag4DSB anurag4DSB force-pushed the improvement/CLDSRV-807-add-rate-limit-fields-to-server-access-logs branch from c88f7d4 to 3cbb5a8 Compare December 10, 2025 07:43
@anurag4DSB
Copy link
Contributor Author

rebased, squashed, added package.json bump and pushed.

@anurag4DSB
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.2

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-807.

Goodbye anurag4dsb.

The following options are set: approve

@bert-e bert-e merged commit 3cbb5a8 into development/9.2 Dec 10, 2025
30 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-807-add-rate-limit-fields-to-server-access-logs branch December 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants