-
Notifications
You must be signed in to change notification settings - Fork 254
CLDSRV-808: PUT/GET bucket logging fix test cleanup #6024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-808: PUT/GET bucket logging fix test cleanup #6024
Conversation
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.2 #6024 +/- ##
===================================================
- Coverage 84.58% 84.57% -0.01%
===================================================
Files 204 204
Lines 12913 12913
===================================================
- Hits 10922 10921 -1
- Misses 1991 1992 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| after(done => { | ||
| Promise.all([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You could use a helper function to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added helper
9f75daf to
8d0956b
Compare
|
ping |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-808. Goodbye leif-scality. The following options are set: approve |
buckets where not deleted when the
beforefailed. Replaced thebeforewithbeforeEachand added anafterglobal call