Skip to content

Conversation

@leif-scality
Copy link
Contributor

@leif-scality leif-scality commented Dec 10, 2025

buckets where not deleted when the before failed. Replaced the before with beforeEach and added an after global call

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2025

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-808 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.8

Please check the Fix Version/s of CLDSRV-808, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.57%. Comparing base (3cbb5a8) to head (be287a3).
⚠️ Report is 2 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph
see 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6024      +/-   ##
===================================================
- Coverage            84.58%   84.57%   -0.01%     
===================================================
  Files                  204      204              
  Lines                12913    12913              
===================================================
- Hits                 10922    10921       -1     
- Misses                1991     1992       +1     
Flag Coverage Δ
ceph-backend-test 66.45% <ø> (-0.02%) ⬇️
file-ft-tests 67.81% <ø> (ø)
kmip-ft-tests 28.16% <ø> (ø)
mongo-v0-ft-tests 69.04% <ø> (-0.03%) ⬇️
mongo-v1-ft-tests 69.06% <ø> (-0.02%) ⬇️
multiple-backend 35.34% <ø> (ø)
sur-tests 36.46% <ø> (+0.77%) ⬆️
sur-tests-inflights 37.51% <ø> (+0.03%) ⬆️
unit 69.89% <ø> (ø)
utapi-v2-tests 34.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

after(done => {
Promise.all([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could use a helper function to avoid duplication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added helper

@leif-scality leif-scality force-pushed the bugfix/CLDSRV-808-bucket-logging-test-cleanup-fix branch from 9f75daf to 8d0956b Compare December 10, 2025 11:59
@leif-scality
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@leif-scality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.2

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-808.

Goodbye leif-scality.

The following options are set: approve

@bert-e bert-e merged commit be287a3 into development/9.2 Dec 10, 2025
30 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-808-bucket-logging-test-cleanup-fix branch December 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants