CLDSRV-809: allow tokens before redis interaction #6025
Merged
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hello anurag4dsb,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 5 files with indirect coverage changes @@ Coverage Diff @@
## development/9.2 #6025 +/- ##
===================================================
- Coverage 84.57% 84.31% -0.26%
===================================================
Files 204 204
Lines 12913 12913
===================================================
- Hits 10921 10888 -33
- Misses 1992 2025 +33
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Workers now start with bufferSize tokens (default 50) instead of 0, enabling fail-open behavior at startup when Redis is unavailable. Previously, new token buckets started empty and required a Redis refill cycle before allowing any requests. This caused all initial requests to be throttled until Redis granted tokens.
Workers now start with bufferSize tokens (default 50) instead of 0, enabling fail-open behavior at startup when Redis is unavailable. Previously, new token buckets started empty and required a Redis refill cycle before allowing any requests. This caused all initial requests to be throttled until Redis granted tokens.
anurag4DSB
force-pushed
the
bugfix/CLDSRV-809-allow-tokens-before-redis-interaction
branch
from
82bb57c to
deb467c
Compare
Contributor
Author
|
rebased with latest dev/9.2 and pushed |
BourgoisMickael
approved these changes
Dec 11, 2025
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Contributor
Author
|
/approve |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: approve |
tmacro
approved these changes
Dec 11, 2025
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-809. Goodbye anurag4dsb. The following options are set: approve |
bert-e
deleted the
bugfix/CLDSRV-809-allow-tokens-before-redis-interaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is default behaviour, which might be modified per strategy used for Redis unavailability which is out of scope of this PR and will be handled in another PR.