INTEGRATION [PR#6022 > development/9.1] adding header handling in routeVeam + unit tests #6029
+154
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to add the handling of additional headers for Veeam routes in the CloudServer. The change actually enables requests with automatically added headers by the sdk to not be directly rejectded. Issue: CLDSRV-806
The image build was failing because we were trying to install pykmip with python v2 (setup.py install uses python command which points to python v2 by default in alpine image). This change checks out the latest commit and installs pykmip with pip3 as this is the one now supported by pykmip. Issue: CLDSRV-806
…additionnal-headers' into w/9.1/improvement/CLDSRV-806-handling-additionnal-headers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.1 #6029 +/- ##
===================================================
+ Coverage 84.12% 84.13% +0.01%
===================================================
Files 193 193
Lines 12337 12346 +9
===================================================
+ Hits 10378 10387 +9
Misses 1959 1959
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bert-e
deleted the
w/9.1/improvement/CLDSRV-806-handling-additionnal-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #6022.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.1/improvement/CLDSRV-806-handling-additionnal-headers, please follow thisprocedure:
git fetch git checkout w/9.1/improvement/CLDSRV-806-handling-additionnal-headers # <amend or cancel the changeset by _adding_ new commits> git push origin w/9.1/improvement/CLDSRV-806-handling-additionnal-headersPlease always comment pull request #6022 instead of this one.