Aws sdk v3 migrations #6042
Aws sdk v3 migrations #6042
Conversation
As test files depend on these utilities, they needed to be adapted to match the sdk v3 requirements. Issue: CLDSRV-724
Issue: CLDSRV-724
Issue: CLDSRV-724
SylvainSenechal
force-pushed
the
improvement/CLDSRV-819
branch
from
574a7cd to
2c88dd1
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
... and 9 files with indirect coverage changes @@ Coverage Diff @@
## development/9.3 #6042 +/- ##
===================================================
- Coverage 84.39% 84.25% -0.14%
===================================================
Files 204 204
Lines 12928 12937 +9
===================================================
- Hits 10910 10900 -10
- Misses 2018 2037 +19
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Waiting for Arsenal release to bump |
SylvainSenechal
force-pushed
the
improvement/CLDSRV-819
branch
from
0ebd8f5 to
6db40db
Compare
SylvainSenechal
requested review from
a team,
DarkIsDude,
benzekrimaha,
francoisferrand and
maeldonn
SylvainSenechal
force-pushed
the
improvement/CLDSRV-819
branch
from
6db40db to
ea3e22f
Compare
There was a problem hiding this comment.
This commit :
- Leif's new feature server access logs : He added tests in ~november-december, using sdk v2 syntax, with a utility client that is now migrated to sdk v3 => I initialized a sdk v2 client directly for those tests, and will migrate to v3 in a separate ticket
- Run this Pr in Zenko and fixed anything that was broken
- Some nits comments last Maha's pr addressed (formatting, tabs etc)
There was a problem hiding this comment.
These are new tests for server access logs : using sdk v2 for now.
The function empty bucket that I added is basically a copy of the one that was in bucket utility (that we can't use because it's v3 compatible)
There was a problem hiding this comment.
This file I don't remember exactly what happened, but I think some miss resolved conflicts or something like that
| }); | ||
|
|
||
|
|
||
| afterEach(done => { | ||
| removeAllVersions({ Bucket: bucketName }, err => { |
There was a problem hiding this comment.
why not keep the fully async implementation of this function?
There was a problem hiding this comment.
removeAllVersions takes a callback. Not sure what happened here, I guess at some point there was an attempt at updating removeAllVersions to be async, but since it's an utility used ~100 times, it was eventually not done
| const objects = objectsRes.slice(0, 1000).map(obj => | ||
| ({ Key: obj.Key, VersionId: obj.VersionId })); | ||
| return s3.deleteObjects({ | ||
|
|
There was a problem hiding this comment.
some spaces at EOL in this file (here & below)
| removeAllVersions({ Bucket: bucketName }, err => { | ||
| if (err) { | ||
| if (err) { |
There was a problem hiding this comment.
missing one leve indent
| it('should send back a DeleteMarkerVersionId matching the versionId ' + | ||
| 'stored for the object if trying to delete an object that does not exist', | ||
| done => { | ||
| s3.deleteObjects({ Bucket: bucketName, | ||
| async () => { | ||
| const deleteRes = await s3.send(new DeleteObjectsCommand({ |
There was a problem hiding this comment.
| it('should send back a DeleteMarkerVersionId matching the versionId ' + | |
| 'stored for the object if trying to delete an object that does not exist', | |
| done => { | |
| s3.deleteObjects({ Bucket: bucketName, | |
| async () => { | |
| const deleteRes = await s3.send(new DeleteObjectsCommand({ | |
| it('should send back a DeleteMarkerVersionId matching the versionId ' + | |
| 'stored for the object if trying to delete an object that does not exist', async () => { | |
| const deleteRes = await s3.send(new DeleteObjectsCommand({ |
lib/routes/routeBackbeat.js
Outdated
| return next(null, currentMD || md || {}); | ||
| }); | ||
| } | ||
|
|
Last adjustements following tests run against cloudserver and Zenko CI Update tests for server access log file to use sdk v2 for now ISSUE: CLDSRV-819
SylvainSenechal
force-pushed
the
improvement/CLDSRV-819
branch
from
ea3e22f to
21363b6
Compare
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-819. Goodbye sylvainsenechal. |
ISSUE: CLDSRV-819