Improvement/charts restructuration #945

JeanMarcMilletScality · 2025-10-15T16:22:57Z

Restructure charts components
Edit utils fn to share logic between charts when possible

Remove Vega

⚠️ This PR remove Vega file and move a lot of files and could break imports

bert-e · 2025-10-15T16:23:01Z

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-10-15T16:23:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-10-17T13:49:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Copilot

Pull Request Overview

This PR restructures the chart components by consolidating them into a unified charts folder, removing the deprecated Vega library, and sharing common logic between chart implementations.

Key Changes:

Removed Vega dependencies (vega, vega-embed, vega-lite, vega-tooltip) and all Vega-based chart implementations
Consolidated all chart components into src/lib/components/charts/ with shared utilities
Created chartUtils.ts to share logic between Barchart and LineTimeSerieChart (unit normalization, tick generation, date formatting)

Reviewed Changes

Copilot reviewed 48 out of 54 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
package.json	Removed Vega library dependencies
src/lib/next.ts	Updated exports to use consolidated charts folder
src/lib/index.ts	Commented out deprecated chart exports
src/lib/components/charts/	New consolidated charts structure with shared utilities
src/lib/components/charts/common/chartUtils.ts	Shared utility functions for unit conversion, tick generation, and date formatting
stories/	Updated imports and removed deprecated story files

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/lib/components/charts/common/chartUtils.ts

Copilot · 2025-10-17T14:20:30Z

src/lib/components/charts/common/chartUtils.ts

+export const maxWidthTooltip = { maxWidth: '20rem' };
+
+/* -------------------------------------------------------------------------- */
+/*                               utils functions                              */


Corrected spelling of 'utils functions' to 'utility functions'.

Suggested change

/* utils functions */

/* utility functions */

src/lib/components/charts/common/chartUtils.test.ts

Copilot · 2025-10-17T14:20:31Z

src/lib/components/charts/linetimeseries/LineTimeSerieChart.utils.ts

- * For 'date' format, return YYYY-MM-DD format if time range is greater than 1 year, otherwise return MM-DD format
+ * Formats timestamp for X-axis labels based on duration
+ *
 *


[nitpick] Extra blank line in JSDoc comment. Remove one of the consecutive blank lines for consistency.

Suggested change

*

Copilot · 2025-10-17T14:20:31Z

src/lib/components/charts/common/chartUtils.ts

+  const numberOfTicks =
+    possibleTickNumbers.find((number) => topValue % (number - 1) === 0) || 2; // Default to 2 ticks if no match


[nitpick] The fallback value of 2 ticks seems arbitrary. Consider documenting why 2 is chosen as the default, or verify this produces reasonable tick spacing for edge cases where no modulo match is found.

Suggested change

const numberOfTicks =

possibleTickNumbers.find((number) => topValue % (number - 1) === 0) || 2; // Default to 2 ticks if no match

// If no modulo match is found, default to 4 ticks for better chart readability.

// This ensures at least start, end, and two intermediate ticks are present.

const numberOfTicks =

possibleTickNumbers.find((number) => topValue % (number - 1) === 0) || 4;

bert-e · 2025-11-20T11:12:20Z

Conflict

There is a conflict between your branch improvement/charts-restructuration and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (improvement/charts-restructuration).

git fetch && \
git checkout origin/improvement/charts-restructuration && \
git merge origin/development/1.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/charts-restructuration

Remove Vega Update core-ui (remove vega deps)

- Introduced `normalizeChartDataWithUnits` for consistent data normalization across Barchart and LineTimeSerieChart. - Updated `formatDate` to `formatXAxisDate` for clarified usage - Added `getTooltipDateFormat` for tooltip date formatting. - Cleaned up imports and removed unused functions in Barchart utilities. - Enhanced type definitions and documentation for better clarity. - Updated tests to cover new functionalities and ensure accuracy.

Return undefined for label if no unitRange

Co-authored-by: Copilot <[email protected]>

Add formatting fn for number

bert-e · 2025-11-20T12:41:40Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Copilot

Pull Request Overview

Copilot reviewed 48 out of 54 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ChengYanJin

LGTM !!

bert-e · 2025-11-28T14:37:20Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JeanMarcMilletScality · 2025-11-28T16:58:49Z

/approve

bert-e · 2025-11-28T16:58:59Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-11-28T16:59:53Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.0

Please check the status of the associated issue None.

Goodbye jeanmarcmilletscality.

JeanMarcMilletScality marked this pull request as ready for review October 17, 2025 14:19

JeanMarcMilletScality requested a review from Copilot October 17, 2025 14:19

Copilot AI reviewed Oct 17, 2025

View reviewed changes

JeanMarcMilletScality and others added 11 commits November 20, 2025 13:34

Regroup charts components into same folder

90abd8b

Remove Vega Update core-ui (remove vega deps)

fix test imports

411dae7

Cleaning import and stories

43e28a2

WIP guideline for charts

167071c

move global helath bar in storybook structure

779760d

improve unitRange type doc + improve tests

7772412

Return undefined for label if no unitRange

Simplify calc for negative ticks

f6864c2

Co-authored-by: Copilot <[email protected]>

fix typo in chartUtils tests

ae6fb87

Co-authored-by: Copilot <[email protected]>

Update PR: Update how topValue for charts are calculated

82a707c

Add formatting fn for number

Update chartUtils test with after changing getRoundReferenceValue logic

5872b07

JeanMarcMilletScality force-pushed the improvement/charts-restructuration branch from d336dc5 to 5872b07 Compare November 20, 2025 12:41

JeanMarcMilletScality requested a review from Copilot November 20, 2025 12:48

Copilot started reviewing on behalf of JeanMarcMilletScality November 20, 2025 12:49 View session

Copilot finished reviewing on behalf of JeanMarcMilletScality November 20, 2025 12:49

Copilot AI reviewed Nov 20, 2025

View reviewed changes

ChengYanJin approved these changes Nov 28, 2025

View reviewed changes

bert-e merged commit 9f56d6d into development/1.0 Nov 28, 2025
10 checks passed

		const numberOfTicks =
		possibleTickNumbers.find((number) => topValue % (number - 1) === 0) \|\| 2; // Default to 2 ticks if no match

Improvement/charts restructuration #945

Improvement/charts restructuration #945

Uh oh!

Conversation

JeanMarcMilletScality commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Oct 15, 2025

Hello jeanmarcmilletscality,

Uh oh!

bert-e commented Oct 15, 2025

Waiting for approval

Uh oh!

bert-e commented Oct 17, 2025

Waiting for approval

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

bert-e commented Nov 20, 2025

Conflict

Uh oh!

bert-e commented Nov 20, 2025

Waiting for approval

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

ChengYanJin left a comment

Choose a reason for hiding this comment

Uh oh!

bert-e commented Nov 28, 2025

Waiting for approval

Uh oh!

JeanMarcMilletScality commented Nov 28, 2025

Uh oh!

bert-e commented Nov 28, 2025

In the queue

Uh oh!

bert-e commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JeanMarcMilletScality commented Oct 15, 2025 •

edited

Loading