-
Notifications
You must be signed in to change notification settings - Fork 8
Add auto-scroll to selected row #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-scroll to selected row #972
Conversation
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
3555f08 to
5abb01f
Compare
…n VirtualizedRows
| RenderRow: React.MemoExoticComponent< | ||
| ({ index, style }: RenderRowType) => JSX.Element | ||
| >; | ||
| listRef?: LegacyRef<FixedSizeList<Row<DATA_ROW>[]>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering should we get rid or LegacyRef ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we should, fixed in 7506203
ChengYanJin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue None. Goodbye hervedombya. |
Component:
Description:
Design:
Breaking Changes:
Closes: #ISSUE_NUMBER