-
Notifications
You must be signed in to change notification settings - Fork 8
Improvement/portal tooltip #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { computePosition, flip, offset, shift } from '@floating-ui/dom'; | ||
| import { CSSProperties, useEffect, useRef, useState } from 'react'; | ||
| import { createPortal } from 'react-dom'; | ||
| import styled from 'styled-components'; | ||
| import { spacing } from '../../spacing'; | ||
| import { fontSize, zIndex } from '../../style/theme'; | ||
|
|
@@ -98,38 +99,42 @@ function Tooltip({ | |
| if (tooltipRef.current) { | ||
| Object.assign(tooltipRef.current.style, { | ||
| opacity: '1', | ||
| // we set opacity to 1 to make sure the tooltip is not displayed before the position is computed | ||
| left: `${x}px`, | ||
| top: `${y}px`, | ||
| }); | ||
| } | ||
| }); | ||
| } | ||
| }, [tooltipRef.current, childrenRef.current, isTooltipVisible]); | ||
| }, [isTooltipVisible, placement]); | ||
| return ( | ||
| <TooltipContainer | ||
| className="sc-tooltip" | ||
| onPointerEnter={() => { | ||
| setIsTooltipVisible(true); | ||
| }} | ||
| onPointerLeave={() => { | ||
| setIsTooltipVisible(false); | ||
| }} | ||
| > | ||
| {isTooltipVisible && overlay ? ( | ||
| <TooltipOverLayContainer | ||
| ref={tooltipRef} | ||
| className="sc-tooltip-overlay" | ||
| placement={placement} | ||
| style={overlayStyle} | ||
| > | ||
| <TooltipText className="sc-tooltip-overlay-text"> | ||
| {overlay} | ||
| </TooltipText> | ||
| </TooltipOverLayContainer> | ||
| ) : null} | ||
| <div ref={childrenRef}>{children}</div> | ||
| </TooltipContainer> | ||
| <> | ||
| <TooltipContainer | ||
| className="sc-tooltip" | ||
| onPointerEnter={() => { | ||
| setIsTooltipVisible(true); | ||
| }} | ||
| onPointerLeave={() => { | ||
| setIsTooltipVisible(false); | ||
| }} | ||
|
Comment on lines
+98
to
+103
|
||
| > | ||
| <div ref={childrenRef}>{children}</div> | ||
| </TooltipContainer> | ||
| {isTooltipVisible && | ||
| overlay && | ||
| createPortal( | ||
| <TooltipOverLayContainer | ||
| ref={tooltipRef} | ||
| className="sc-tooltip-overlay" | ||
| placement={placement} | ||
| style={overlayStyle} | ||
| > | ||
| <TooltipText className="sc-tooltip-overlay-text"> | ||
| {overlay} | ||
| </TooltipText> | ||
| </TooltipOverLayContainer>, | ||
| document.body, | ||
| )} | ||
ChengYanJin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </> | ||
| ); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The useEffect dependencies array is missing
childrenRefandtooltipRef. The effect useschildrenRef.currentandtooltipRef.currentinternally. While refs themselves don't change, this could lead to stale closures. Consider adding these refs to the dependency array or using a callback ref pattern to ensure proper updates when the refs are set.