Improvement/artesca 16534 chart axis issues #991

JeanMarcMilletScality · 2026-01-21T17:19:30Z

No description provided.

… the starting point and legend Improve sorting for symmetrical chart: avoid missing separator when below values is 0 display <0.01 in tooltip when values are too small Fix issue with inconsistent tooltip display when switching for one chart to another: multiple chart tooltip coud be displayed, so add a check on which chart is active and only display tooltip for this chart

bert-e · 2026-01-21T17:19:34Z

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-01-21T17:19:40Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

…art.tsx is now focused on chart rendering, logic has been moved to 2 hook files: useChrtdata and useChartHover, and tooltip has its own file Issue with inconsistent tooltip on hover was not fixed with previous commit: change logic so Tooltip is checking on render which chart is the hovered one

bert-e · 2026-01-21T17:42:05Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

- Improve rounding logic - Improve tick formatting by using ISO formatting fn

…ent to use formatISONumber utility. Update logic to handle large, normal, small, and very small values with appropriate notation.

… cases with all zero values. Set topValue and topDomain to 1 for better representation.

bert-e · 2026-01-23T16:38:34Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

- Utilize useMemo for colorSet calculation to optimize rendering - Implement useCallback for tickFormatter to enhance performance - Clean up conditional rendering logic for loading and error states - Update getTicks function signature for clarity - Fix typo in parameter name in normalizeChartDataWithUnits function

… and simplify tooltip hover logic. Update related types and components for consistency.

bert-e · 2026-01-23T17:23:46Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ziyang-lin-404 · 2026-01-26T09:52:08Z

src/lib/components/charts/linetimeseries/LineTimeSerieChart.tsx

-                    onMouseEnter={() => setHoveredValue(label)}
-                    onMouseLeave={() => setHoveredValue(undefined)}


The Line components previously had onMouseEnter/onMouseLeave handlers that updated hoveredValue state, which was used to highlight the corresponding item in the
tooltip (via isHovered prop on ChartTooltipItem). This appears to have been removed. Was this intentional, or should the hover highlighting be preserved?

bert-e · 2026-01-26T09:52:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

… thzt became unnecessary after simplification of useChartHover

bert-e · 2026-01-26T12:34:42Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JeanMarcMilletScality · 2026-01-29T09:43:15Z

/approve

bert-e · 2026-01-29T09:43:25Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2026-01-29T09:44:21Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.0

Please check the status of the associated issue ARTESCA-16534.

Goodbye jeanmarcmilletscality.

JeanMarcMilletScality added 2 commits January 21, 2026 17:49

Add story for empty charts

ffb9389

JeanMarcMilletScality added 6 commits January 23, 2026 17:28

Add formatISONumber utility function for ISO 80000-1 number formatting

c697a3f

Improve Y axis for charts

e743731

- Improve rounding logic - Improve tick formatting by using ISO formatting fn

Refactor tooltip value formatting in LineTimeSerieChartTooltip compon…

9f32ed4

…ent to use formatISONumber utility. Update logic to handle large, normal, small, and very small values with appropriate notation.

Update default values for empty charts in useChartData hook to handle…

be5b9a9

… cases with all zero values. Set topValue and topDomain to 1 for better representation.

Add compare cases stories for Y axis

33ca418

fix typo in title

ffc35fb

JeanMarcMilletScality added 3 commits January 23, 2026 18:22

Update test for rounding value fn

ff9e305

Refactor LineTimeSerieChart to remove isChartHovered state management…

8ea8a74

… and simplify tooltip hover logic. Update related types and components for consistency.

JeanMarcMilletScality marked this pull request as ready for review January 23, 2026 17:25

ziyang-lin-404 reviewed Jan 26, 2026

View reviewed changes

move back onMouse handlers on Line chart and remove intermediate div,…

82645e9

… thzt became unnecessary after simplification of useChartHover

ziyang-lin-404 approved these changes Jan 26, 2026

View reviewed changes

bert-e merged commit b2abedb into development/1.0 Jan 29, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/artesca 16534 chart axis issues #991

Improvement/artesca 16534 chart axis issues #991

Uh oh!

JeanMarcMilletScality commented Jan 21, 2026

Uh oh!

bert-e commented Jan 21, 2026

Uh oh!

bert-e commented Jan 21, 2026

Uh oh!

bert-e commented Jan 21, 2026

Uh oh!

bert-e commented Jan 23, 2026

Uh oh!

bert-e commented Jan 23, 2026

Uh oh!

ziyang-lin-404 Jan 26, 2026

Uh oh!

bert-e commented Jan 26, 2026

Uh oh!

bert-e commented Jan 26, 2026

Uh oh!

JeanMarcMilletScality commented Jan 29, 2026

Uh oh!

bert-e commented Jan 29, 2026

Uh oh!

bert-e commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		onMouseEnter={() => setHoveredValue(label)}
		onMouseLeave={() => setHoveredValue(undefined)}

Improvement/artesca 16534 chart axis issues #991

Improvement/artesca 16534 chart axis issues #991

Uh oh!

Conversation

JeanMarcMilletScality commented Jan 21, 2026

Uh oh!

bert-e commented Jan 21, 2026

Hello jeanmarcmilletscality,

Uh oh!

bert-e commented Jan 21, 2026

Waiting for approval

Uh oh!

bert-e commented Jan 21, 2026

Waiting for approval

Uh oh!

bert-e commented Jan 23, 2026

Waiting for approval

Uh oh!

bert-e commented Jan 23, 2026

Waiting for approval

Uh oh!

ziyang-lin-404 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

bert-e commented Jan 26, 2026

Waiting for approval

Uh oh!

bert-e commented Jan 26, 2026

Waiting for approval

Uh oh!

JeanMarcMilletScality commented Jan 29, 2026

Uh oh!

bert-e commented Jan 29, 2026

In the queue

Uh oh!

bert-e commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants