Skip to content

Table selected row misalignment #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bert-e merged 2 commits into from
Jan 26, 2026
Merged

Table selected row misalignment #993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab2392d
replace adding border with bow shadow to keep visual effect (blue bar…
JeanMarcMilletScality Jan 22, 2026
bb093fe
Remove unused Box import in Tablestyle.tsx
JeanMarcMilletScality Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/lib/components/tablev2/Tablestyle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { HeaderGroup } from 'react-table';
import { Icon } from '../icon/Icon.component';
import { FocusVisibleStyle } from '../buttonv2/Buttonv2.component';
import { spacing } from '../../spacing';
import { Box } from '../box/Box';
Copy link
Contributor

@ziyang-lin-404 ziyang-lin-404 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should format first, this line change nothing


const borderSize = '4px';
export const SortIncentive = styled.span`
Expand Down Expand Up @@ -65,7 +64,6 @@ export const HeadRow = styled.div<HeadRowType>`
overflow: hidden;
border-bottom: 1px solid
${(props) => props.theme[props.separationLineVariant]};
padding-right: ${borderSize};
padding-left: ${spacing.r16};
`;

Expand Down Expand Up @@ -105,7 +103,7 @@ export const TableRow = styled.div<TableRowType>`
if (props.selectedId && props.isSelected) {
return css`
background-color: ${props.theme.highlight};
border-right: ${borderSize} solid ${props.theme.selectedActive};
box-shadow: inset -${borderSize} 0 0 ${props.theme.selectedActive};
`;
}
}}
Expand All @@ -124,7 +122,7 @@ export const TableRowMultiSelectable = styled.div<TableRowMultiSelectableType>`
if (props.isSelected) {
return css`
background-color: ${(props) => props.theme.highlight};
border-right: ${borderSize} solid ${props.theme.selectedActive};
box-shadow: inset -${borderSize} 0 0 ${props.theme.selectedActive};
`;
}
}}
Expand Down
Loading