LOGC-46: Fix DateTime64 millisecond truncation in LogFetcher#95
Merged
LOGC-46: Fix DateTime64 millisecond truncation in LogFetcher#95
Conversation
The ClickHouse Go driver truncates milliseconds when binding time.Time to DateTime64(3) parameters. Convert startTime to Unix epoch string format to preserve millisecond precision in queries.
leif-scality
approved these changes
Jan 23, 2026
anurag4DSB
approved these changes
Jan 23, 2026
BourgoisMickael
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This substitutes #90 with a much simpler fix.
The issue is that the ClickHouse Go driver truncates milliseconds when binding time.Time to
DateTime64(3)parameters.I wrote a simple script that reproduces the issue
With the following table:
when we insert with
we get
but when we also insert
we get
The fix is to apply this conversion to log-courier