-
Notifications
You must be signed in to change notification settings - Fork 11
(PTFE-2737) Add packer setup for rocky #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 84.91% 85.11% +0.19%
==========================================
Files 35 35
Lines 1545 1545
==========================================
+ Hits 1312 1315 +3
+ Misses 233 230 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c08feb8 to
628209b
Compare
cmeron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthiasL-scality Can you explain the expected lifecycle of the created images here ?
Is this to be run only manuall when a new minor OS version is released ?
(I'm wondering if we should think of some cleanup mechanism if it's automatic)
|
@cmeron the cleanup + build process will be done here https://scality.atlassian.net/browse/PTFE-2738, you can have an eye on the workflow on this branch (main...PTFE-2738-add-github-action-to-rebuild-image) to resume : each sunday we will rebuild a new image, do a clean up to keep the last three image, and when building the runner manager will get the most recent image |
Ok great then ! |
628209b to
975d747
Compare
| echo | ||
|
|
||
| # Get configuration | ||
| read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID | |
| read -p "Enter GCP Project ID [my-gcp-project]: " PROJECT_ID |
|
|
||
| # Get configuration | ||
| read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID | ||
| PROJECT_ID=${PROJECT_ID:-scality-prod-ga-runners} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| PROJECT_ID=${PROJECT_ID:-scality-prod-ga-runners} | |
| PROJECT_ID=${PROJECT_ID:-my-gcp-project} |
Purpose
Add packer for rocky