Skip to content

Conversation

@matthiasL-scality
Copy link
Contributor

Purpose

Add packer for rocky

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner November 3, 2025 15:02
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (c28657f) to head (975d747).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   84.91%   85.11%   +0.19%     
==========================================
  Files          35       35              
  Lines        1545     1545              
==========================================
+ Hits         1312     1315       +3     
+ Misses        233      230       -3     
Flag Coverage Δ
api 62.84% <ø> (ø)
unit 67.24% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trunk-io
Copy link

trunk-io bot commented Nov 3, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2737-add-packer-setup-for-rocky branch from c08feb8 to 628209b Compare November 4, 2025 08:54
Copy link

@cmeron cmeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthiasL-scality Can you explain the expected lifecycle of the created images here ?
Is this to be run only manuall when a new minor OS version is released ?

(I'm wondering if we should think of some cleanup mechanism if it's automatic)

@matthiasL-scality
Copy link
Contributor Author

@cmeron the cleanup + build process will be done here https://scality.atlassian.net/browse/PTFE-2738, you can have an eye on the workflow on this branch (main...PTFE-2738-add-github-action-to-rebuild-image)

to resume : each sunday we will rebuild a new image, do a clean up to keep the last three image, and when building the runner manager will get the most recent image

@cmeron
Copy link

cmeron commented Nov 4, 2025

@cmeron the cleanup + build process will be done here https://scality.atlassian.net/browse/PTFE-2738, you can have an eye on the workflow on this branch (main...PTFE-2738-add-github-action-to-rebuild-image)

Ok great then !

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2737-add-packer-setup-for-rocky branch from 628209b to 975d747 Compare November 5, 2025 08:31
echo

# Get configuration
read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID
read -p "Enter GCP Project ID [my-gcp-project]: " PROJECT_ID


# Get configuration
read -p "Enter GCP Project ID [scality-prod-ga-runners]: " PROJECT_ID
PROJECT_ID=${PROJECT_ID:-scality-prod-ga-runners}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PROJECT_ID=${PROJECT_ID:-scality-prod-ga-runners}
PROJECT_ID=${PROJECT_ID:-my-gcp-project}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants