Skip to content

improvement(PTFE-3166): update GitHub Actions to Node 24-compatible versions #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JBWatenbergScality wants to merge 3 commits into
base: main
Choose a base branch
from
Open

improvement(PTFE-3166): update GitHub Actions to Node 24-compatible versions #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60e2ea4
improvement(PTFE-3166): update GitHub Actions to Node 24-compatible v…
JBWatenbergScality Apr 14, 2026
8f1f2c5
ci: also upgrade docker/build-push-action@v6→v7, metadata-action@v5→v…
JBWatenbergScality Apr 14, 2026
9bc8532
ci(dependabot): bump actions/create-github-app-token from v1 to v3
JBWatenbergScality Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Install Poetry
run: |
pipx install poetry
- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: 3.x
cache: poetry
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
is_fork: ${{ steps.fork.outputs.is_fork }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Identify if the PR comes from a fork
id: fork
run: echo "is_fork=$(gh pr view --json isCrossRepository --jq .isCrossRepository)" >> $GITHUB_OUTPUT
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/codeql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
uses: github/codeql-action/init@v4
with:
languages: python

- name: Build and analyze
uses: github/codeql-action/analyze@v3
uses: github/codeql-action/analyze@v4
4 changes: 2 additions & 2 deletions .github/workflows/dependabot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
# Checking the author will prevent your Action run failing on non-Dependabot PRs
if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' }}
steps:
- uses: actions/create-github-app-token@v1
- uses: actions/create-github-app-token@v3
id: app-token
with:
app-id: ${{ vars.ACTIONS_APP_ID }}
Expand All @@ -28,7 +28,7 @@ jobs:
uses: dependabot/fetch-metadata@v2
Copy link
Copy Markdown

@claude claude bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot/fetch-metadata@v2 was not updated. Verify it is already Node 24-compatible or bump to a newer major version.

— Claude Code

Copy link
Copy Markdown

@claude claude bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot/fetch-metadata@v2 still uses Node 20. v3 is the Node 24-compatible version.

```suggestion
uses: dependabot/fetch-metadata@v3


- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
lfs: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Dependency Review
uses: actions/dependency-review-action@v4
Copy link
Copy Markdown

@claude claude bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/dependency-review-action@v4 was not updated. Verify it is already Node 24-compatible or bump to a newer major version.

— Claude Code

4 changes: 2 additions & 2 deletions .github/workflows/deploy-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Install Poetry
run: pipx install poetry
- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: 3.x
cache: poetry
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
test-deployment:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4
- name: Build runner-manager image
uses: docker/build-push-action@v6
uses: docker/build-push-action@v7
with:
context: .
push: false
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ jobs:
GITHUB_BASE_URL: http://localhost:4010
TRUNK_TOKEN: ${{ secrets.TRUNK_TOKEN }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Boot compose services
run: docker compose --profile tests up --build --detach
- run: pipx install poetry
- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: 3.11
cache: poetry
Expand All @@ -43,7 +43,7 @@ jobs:
env:
GITHUB_TOKEN: test
- name: Upload coverage
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v6
with:
flags: ${{ matrix.test.name }}
name: ${{ matrix.test.name }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/trunk-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- run: pipx install poetry
- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: 3.11
cache: poetry
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/vsphere.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
REDIS_OM_URL: redis://localhost:6379/0
GITHUB_BASE_URL: http://localhost:4010
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Boot compose services
run: docker compose --profile tests up --build --detach
- run: |
Expand All @@ -38,7 +38,7 @@ jobs:
pipx install poetry
- name: ensure .local/bin is in PATH
run: echo "$HOME/.local/bin" >> $GITHUB_PATH
- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: 3.11
cache: poetry
Expand All @@ -54,7 +54,7 @@ jobs:
GOVC_DATACENTER: ${{ secrets.GOVC_DATACENTER }}
GOVC_DATASTORE: ${{ secrets.GOVC_DATASTORE }}
- name: Upload coverage
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v6
with:
flags: vsphere
name: vsphere
Expand Down
Loading