Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 25, 2025

We had the account->locations mapping, but not for buckets. This PR updates the logic so we have the per-location info for buckets as well.

Issue: S3UTILS-170

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@ghost ghost force-pushed the improvement/S3UTILS-170 branch 2 times, most recently from 3fb4ff7 to c456807 Compare March 25, 2025 09:32
@ghost ghost requested review from benzekrimaha, francoisferrand and welansari March 25, 2025 10:07
@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@ghost ghost deleted a comment from bert-e Mar 25, 2025
Copy link
Contributor

@anurag4DSB anurag4DSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code assumes that all the fields in dataMetrics.location[location].usedCapacity and objectCount exist and are BigInts. If that's okay, LGTM, left some comments.

@ghost ghost force-pushed the improvement/S3UTILS-170 branch from c456807 to d734478 Compare March 26, 2025 09:10
@ghost ghost force-pushed the improvement/S3UTILS-170 branch from d734478 to 6c7851f Compare March 26, 2025 09:12
@ghost ghost changed the base branch from development/1.14 to development/1.15 March 26, 2025 09:13
@ghost ghost deleted a comment from bert-e Mar 26, 2025
@bert-e
Copy link
Contributor

bert-e commented Mar 26, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@ghost
Copy link
Author

ghost commented Apr 4, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 4, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.15

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.4

Please check the status of the associated issue S3UTILS-170.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit 6c7851f into development/1.15 Apr 4, 2025
10 checks passed
@bert-e bert-e deleted the improvement/S3UTILS-170 branch April 4, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants