-
Notifications
You must be signed in to change notification settings - Fork 2
Support per-location metrics in bucket #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
3fb4ff7 to
c456807
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
anurag4DSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code assumes that all the fields in dataMetrics.location[location].usedCapacity and objectCount exist and are BigInts. If that's okay, LGTM, left some comments.
c456807 to
d734478
Compare
d734478 to
6c7851f
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-170. Goodbye williamlardier. The following options are set: approve |
We had the account->locations mapping, but not for buckets. This PR updates the logic so we have the per-location info for buckets as well.
Issue: S3UTILS-170