Improvement/s3 utils 171 bump deps by benzekrimaha · Pull Request #336 · scality/s3utils

benzekrimaha · 2025-04-09T10:06:03Z

bert-e · 2025-04-09T10:06:07Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-04-11T15:24:31Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

ghost

Adding this one as well: https://github.com/scality/s3utils/actions/runs/14406521365/job/40404317245#step:9:26

We can just replace "ephemeralForTest" with "wiredTiger", it'll just work

CompareRaftMembers/BlockDigestsStorage.js

CountItems/CountWorkerObj.js

Dockerfile

StalledRetry/StalledRequestHandler.js

repairDuplicateVersionIds.js

verifyBucketSproxydKeys.js

bert-e · 2025-04-15T07:57:51Z

Incorrect fix version

The Fix Version/s in issue S3UTILS-171 contains:

1.16.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.15.9

Please check the Fix Version/s of S3UTILS-171, or the target
branch of this pull request.

francoisferrand · 2025-04-15T08:00:02Z

this PR should target a new branch, to ensure we don't introduce breaking change

bert-e · 2025-04-15T09:28:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

CRR/ReplicationStatusUpdater.js

CompareRaftMembers/BlockDigestsStorage.js

CountItems/CountManager.js

CountItems/CountWorkerObj.js

francoisferrand · 2025-04-15T12:52:41Z

CountItems/CountWorkerObj.js

+            if (data.owner !== 'scality') {return;}
            const cb = this._getCallback(data.id);
-            if (!cb) return;
+            if (!cb) {return;}


francoisferrand · 2025-04-15T12:53:36Z

StalledRetry/StalledRequestHandler.js


    queueSetup() {
-        this._queue = async.queue(({ bucket, batch, getNext }, done) => {
+        this._queue = async.queue((task, done) => {


why the change? is it not working anymore, or flagged by eslint?

not working anymore with the async bump

that is weird, should be purely a node "syntax" thing, unrelated to async :-/

StalledRetry/StalledRequestHandler.js

francoisferrand · 2025-04-15T12:55:23Z

VerifyReplication/verifyReplication.js

            listingLimit,
-        };
-        // eslint-disable-next-line no-use-before-define
+        };       


extra space at EOL

compareBuckets/compareBuckets.js

service-level-sidecar/bucketd.js

Dockerfile

francoisferrand · 2025-04-15T13:19:33Z

Dockerfile

@@ -1,4 +1,4 @@
-ARG NODE_VERSION=16.20.2-bullseye-slim
+ARG NODE_VERSION=22.14.0-bookworm



At the moment, the image includes python, for the scripts in the utapi folder (c.f. https://scality.atlassian.net/browse/S3UTILS-172)

With the upgrade, a newer version of python will be used: so we need to check that the scripts still work (or find a way to remove them and drop python from the image, i.e. move forward with s3utils-172...)

there is now 22.15.0-bookworm-slim, should we use it?
or just "plan" a global bump from 22.14 to 22.15 ?

Dockerfile

CountItems/CountManager.js

StalledRetry/StalledRequestHandler.js

compareBuckets/compareBuckets.js

package.json

eslint.config.mjs

ghost

You can add a commit to bump if you want 🙂

ghost · 2025-04-22T14:40:29Z

tests/constants.js

        },
        ingestion: null,
    },
+    InternalTestBucketMD: {


Suggested change

InternalTestBucketMD: {

internalTestBucketMD: {

ghost · 2025-04-22T14:44:29Z

There is also a unit test failure that requires attention, as it affects a sub dependency...

CountItems/CountWorker.js

compareBuckets/compareBuckets.js

Issue: S3UTILS-171

benzekrimaha · 2025-04-30T17:03:50Z

/approve

- The async module bump lead to the need of using callbacks on functions like doWhilst. - Also we need to add for mongo some parameters to have the expected return , in this specific case returnDocument: 'after', includeResultMetadata: true. - In our tests, bucketInfos used to send an empty array, this commit actually uses fill to send the intended array as before async used to just ignore the empty array and return the expected result. Issue: S3UTILS-171

bert-e · 2025-05-06T12:40:29Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.16

The following branches have NOT changed:

development/1.13
development/1.14
development/1.15
development/1.4

Please check the status of the associated issue S3UTILS-171.

Goodbye benzekrimaha.

The following options are set: approve

benzekrimaha changed the base branch from development/1.14 to development/1.15 April 9, 2025 10:06

benzekrimaha force-pushed the improvement/S3UTILS-171-bump-deps branch 3 times, most recently from ad3aed3 to f3c0a03 Compare April 11, 2025 15:23

scality deleted a comment from bert-e Apr 11, 2025

benzekrimaha marked this pull request as ready for review April 11, 2025 15:24

ghost reviewed Apr 14, 2025

View reviewed changes

benzekrimaha changed the base branch from development/1.15 to development/1.16 April 15, 2025 09:27

benzekrimaha force-pushed the improvement/S3UTILS-171-bump-deps branch from cace95a to a521e50 Compare April 15, 2025 10:02