Skip to content

Conversation

@DarkIsDude
Copy link
Contributor

No description provided.

@DarkIsDude DarkIsDude self-assigned this Sep 18, 2025
@bert-e
Copy link
Contributor

bert-e commented Sep 18, 2025

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 18, 2025

Incorrect fix version

The Fix Version/s in issue UTAPI-117 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.4

Please check the Fix Version/s of UTAPI-117, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Sep 18, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@anurag4DSB
Copy link
Contributor

anurag4DSB commented Sep 19, 2025

Can we have the issue number in the commit message for proper tracking?
https://scality.atlassian.net/wiki/spaces/ENG/pages/2038005821/Code+Review+Standard?focusedCommentId=3405545637

Screenshot 2025-09-19 at 17 32 15

@DarkIsDude DarkIsDude force-pushed the feature/UTAPI-117/fix-bitnami-image branch from 2a67c36 to aa8eb1a Compare September 19, 2025 15:35
@DarkIsDude
Copy link
Contributor Author

Can we have the issue number in the commit message for proper tracking? https://scality.atlassian.net/wiki/spaces/ENG/pages/2038005821/Code+Review+Standard?focusedCommentId=3405545637

Screenshot 2025-09-19 at 17 32 15

@anurag4DSB done 🙏

@anurag4DSB
Copy link
Contributor

Can we have the issue number in the commit message for proper tracking? https://scality.atlassian.net/wiki/spaces/ENG/pages/2038005821/Code+Review+Standard?focusedCommentId=3405545637

Screenshot 2025-09-19 at 17 32 15

@anurag4DSB done 🙏

Can we also remove the emoji from the commit mesaage so that that if the font is not installed it doesnt break the systems and tools.

@DarkIsDude
Copy link
Contributor Author

DarkIsDude commented Sep 22, 2025

Can we also remove the emoji from the commit mesaage so that that if the font is not installed it doesnt break the systems and tools.

@anurag4DSB Do we have an agreement on that ? Gitmoji is pretty standard and I started to use it as some others do https://github.com/scality/artesca/commit/9fb645584cc28b55537f53c9166b0b259e5f8973. I'll remove it but I would like to know for next PR / commit message.

@anurag4DSB
Copy link
Contributor

anurag4DSB commented Sep 22, 2025

Can we also remove the emoji from the commit mesaage so that that if the font is not installed it doesnt break the systems and tools.

@anurag4DSB Do we have an agreement on that ? Gitmoji is pretty standard and I started to use it as some others do scality/artesca@9fb6455. I'll remove it but I would like to know for next PR / commit message.

Thanks for raising this. While Gitmoji is common in some projects, it isn’t consistently supported across all systems and tools we use, and can lead to readability or compatibility issues. To keep commit history reliable and portable, let’s avoid emojis in commit messages.

@DarkIsDude DarkIsDude force-pushed the feature/UTAPI-117/fix-bitnami-image branch from aa8eb1a to 46c8874 Compare September 22, 2025 11:52
@DarkIsDude
Copy link
Contributor Author

Thanks for raising this. While Gitmoji is common in some projects, it isn’t consistently supported across all systems and tools we use, and can lead to readability or compatibility issues. To keep commit history reliable and portable, let’s avoid emojis in commit messages.

That's done. Can you be more precise, I would start a new confluence page to make sure we can support Gitmoji as I (and I'm not the only one) like it 🙏

@DarkIsDude
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 29, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue UTAPI-117.

Goodbye darkisdude.

The following options are set: approve

@bert-e bert-e merged commit 46c8874 into development/8.2 Sep 29, 2025
15 checks passed
@bert-e bert-e deleted the feature/UTAPI-117/fix-bitnami-image branch September 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants