Skip to content

Commit c0ec51d

Browse files
authored
Merge pull request ClickHouse#73617 from ClickHouse/hanfei/remove_if_exists_for_backup_s3_writer
enable IfExists remove file for BackupWriterS3
2 parents 90df6bc + 376e08c commit c0ec51d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Backups/BackupIO_S3.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ std::unique_ptr<WriteBuffer> BackupWriterS3::writeFile(const String & file_name)
378378

379379
void BackupWriterS3::removeFile(const String & file_name)
380380
{
381-
deleteFileFromS3(client, s3_uri.bucket, fs::path(s3_uri.key) / file_name, /* if_exists = */ false,
381+
deleteFileFromS3(client, s3_uri.bucket, fs::path(s3_uri.key) / file_name, /* if_exists = */ true,
382382
blob_storage_log);
383383
}
384384

@@ -392,7 +392,7 @@ void BackupWriterS3::removeFiles(const Strings & file_names)
392392
/// One call of DeleteObjects() cannot remove more than 1000 keys.
393393
size_t batch_size = 1000;
394394

395-
deleteFilesFromS3(client, s3_uri.bucket, keys, /* if_exists = */ false,
395+
deleteFilesFromS3(client, s3_uri.bucket, keys, /* if_exists = */ true,
396396
s3_capabilities, batch_size, blob_storage_log);
397397
}
398398

0 commit comments

Comments
 (0)