Send multicast requests on all adapters

[tstenner]

There have been some more bug reports with streams no / only one stream being found.

Currently, the "I'm looking for a stream"-multicast packets are only sent on one network adapter (on Linux it can be configured otherwise manually, but it ought to work out of the box).

So, this PR adds another config option for all local adapters multicast packets should be sent from, in case it's empty it's generated automatically (currently not yet working on Windows and not tested locally on macOS, but the previously failing CI is happy) and sends the multicast packets once for each configured adapter.

[cboulay]

My only comment/suggestions is in the above review about where to combine the config-provided interfaces and the hardware-polled interfaces.

As far as I can tell, the reset of the code changes are related to storing addresses as ips instead of strings, and pre-emptive error handling. All good stuff.

[scott86]

@tstenner I just want to let you know that this PR is working great on our bridged lab systems (both linux). Previously we were using master and could not see any remote streams between the two.

[behinger]

hey! Trying to include this pull request in my linux installation (one direct LAN connection, one university LAN + wifi Connection, should look out for streams on the direct LAN and the wifi) - but so far no success.

1. I checked out the pull request, and ran standalone_compilation_linux.sh.
2. I copied the generated liblsl.so to pylsl/lib/ and installed it using pip install .
3. I tried recording a stream using examples/ReceiveData.py -> but I cannot find anything.

I generally don't really know how to debug this issue, any pointers would be greatly appreciated!

[cboulay]

@behinger

I copied the generated liblsl.so to pylsl/lib/ and installed it using pip install .

Depending on the pylsl source version you're using, this might not do anything. Can you try putting your new liblsl.so somewhere it can be found AFTER you do pip install?

See the pylsl find_liblsl_libraries code. For your initial tests, the easiest is to set an environment variable PYLSL_LIB=path/to/custom/liblsl.so python myscript.py.

[behinger]

Thank you! I did something stupid 🙈 I checked out the PR but didnt switch to the branch. Now it works flawlessly! Super cool!

[behinger]

is this PR actually pulled into the release? It appears in the releasenotes, but it didnt work for me. It is also not marked as pulled in this PR.

[tstenner]

No idea why it wasn't merged properly, but I have merged it manually (again).