Merged
Conversation
Owner
schatty
commented
Jul 17, 2025
schatty
commented
- Structure refactor
- UV + Ruff Support
- Gymnasium Env Support
- Type Annotations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #20 +/- ##
===========================================
+ Coverage 85.85% 91.92% +6.07%
===========================================
Files 8 17 +9
Lines 594 793 +199
===========================================
+ Hits 510 729 +219
+ Misses 84 64 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schatty
added a commit
that referenced
this pull request
Jul 17, 2025
* Upgrade requirements * fixes for running both dm_control and safety gymnasium * Add basic ci file * Add ci file * Add dockerfile * Change ci file to use docker * change ci * rename jobs * change jobs name * Add test coverage * feature: add codecov icon to readme * Add tests for safety gymnasium (#19) * Add tests for safety gymnasium * Install SafetyGymnasium into Dockerfile * Change tests coverage in CI * Fix typo * Implement factory pattern for rl algos * Make rl algos dataclasses * Feature/refactor (#20) * Move configs from package and refine * Replace inheritance with composition for trainer, make visualization script * Refactor replay buffer * Refactor environment module * Add new environment files * Remove utils folder * Make trainers dataclasses * Add option for storing logs outside src folder, make logs dir creation common code * Introduce explicit protocols * Introduce base algorithm with explore and exploit functionality * Ensure algo and buffer has been created in trainer * Add proper stdout logging instead of bare prints * Make algos configurable * Replace bare dict with pydantic config in configs * Refine annotations * Make distrib code work * Refactor distrib training * Add explicit gymnasium support * Fix: gymnasium support * Add uv ruff * Add uv to dockerfile and ci * Add tests * Add mypy check for custom modules * Add ruff to ci pipeline * Fix in ci * Fix ci * Fix mypy typo in ci * Add missing module file * Exclude runners * Update README.md * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.